You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/08/10 04:54:03 UTC

[GitHub] [skywalking] zhaoyuguang opened a new pull request #3239: Unified http status code usage

zhaoyuguang opened a new pull request #3239: Unified http status code usage
URL: https://github.com/apache/skywalking/pull/3239
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   Unify the http status code usage, just like the following code
   ```java
   if (statusCode >= 400) {
       AbstractSpan span = ContextManager.activeSpan().errorOccurred();
       Tags.STATUS_CODE.set(span, String.valueOf(statusCode));
   }}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services