You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/29 05:47:30 UTC
[GitHub] [iotdb] RYH61 opened a new pull request, #7156: [IOTDB-4253] Modify the jdbc query time column to be empty
RYH61 opened a new pull request, #7156:
URL: https://github.com/apache/iotdb/pull/7156
When the query statement is executed with jdbc, when the last column of the previous row is empty, the next row last Read Was Null will still be true, resulting in the Timestamp column not displaying time information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #7156: [IOTDB-4253] Modify the jdbc query time column to be empty
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #7156:
URL: https://github.com/apache/iotdb/pull/7156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #7156: [IOTDB-4253] Modify the jdbc query time column to be empty
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on code in PR #7156:
URL: https://github.com/apache/iotdb/pull/7156#discussion_r957013875
##########
integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/IoTDBAggregationIT.java:
##########
@@ -990,9 +990,24 @@ public void timeWasNullTest() throws Exception {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
- try (ResultSet resultSet =
- statement.executeQuery(
- "select max_value(temperature),count(status) from root.ln.wf01.wt01 group by ([0, 600), 100ms)")) {
+ // create timeseries
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s1 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s2 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s3 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+
+ for (int i = 0; i < 10; i++) {
+ statement.addBatch(
+ "insert into root.sg1.d1(timestamp, s1, s2) values(" + i + "," + 1 + "," + 1 + ")");
+ }
+
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(103, 1)");
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(104, 1)");
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(105, 1)");
+ statement.executeBatch();
+ try (ResultSet resultSet = statement.executeQuery("select * from root.**")) {
Review Comment:
Add a new one IT case instead of modifying the previous one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] RYH61 commented on a diff in pull request #7156: [IOTDB-4253] Modify the jdbc query time column to be empty
Posted by GitBox <gi...@apache.org>.
RYH61 commented on code in PR #7156:
URL: https://github.com/apache/iotdb/pull/7156#discussion_r957063216
##########
integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/IoTDBAggregationIT.java:
##########
@@ -990,9 +990,24 @@ public void timeWasNullTest() throws Exception {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
- try (ResultSet resultSet =
- statement.executeQuery(
- "select max_value(temperature),count(status) from root.ln.wf01.wt01 group by ([0, 600), 100ms)")) {
+ // create timeseries
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s1 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s2 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+ statement.execute(
+ "CREATE TIMESERIES root.sg1.d1.s3 WITH DATATYPE=INT64, ENCODING=RLE, COMPRESSOR=SNAPPY");
+
+ for (int i = 0; i < 10; i++) {
+ statement.addBatch(
+ "insert into root.sg1.d1(timestamp, s1, s2) values(" + i + "," + 1 + "," + 1 + ")");
+ }
+
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(103, 1)");
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(104, 1)");
+ statement.execute("insert into root.sg1.d1(timestamp, s3) values(105, 1)");
+ statement.executeBatch();
+ try (ResultSet resultSet = statement.executeQuery("select * from root.**")) {
Review Comment:
please see https://github.com/apache/iotdb/pull/5281
It is not appropriate to put it here. I have moved it to IoTDBResultSetIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org