You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by etzelc <gi...@git.apache.org> on 2017/07/14 13:49:38 UTC
[GitHub] maven pull request #128: [MNG-6256] Surround variables in echo command with ...
GitHub user etzelc opened a pull request:
https://github.com/apache/maven/pull/128
[MNG-6256] Surround variables in echo command with double quotes
This is a patch for issue MNG-6256. https://issues.apache.org/jira/browse/MNG-6256
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/etzelc/maven MNG-6256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit f578a733ade77c3d11186c395d1d5199a65f532d
Author: Christoph Etzel <ch...@informatik.uni-augsburg.de>
Date: 2017-07-14T08:26:06Z
[MNG-6256] Surround variables in echo command with double quotes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Posted by Tunaki <gi...@git.apache.org>.
Github user Tunaki commented on the issue:
https://github.com/apache/maven/pull/128
Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`? [`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150) and [`${arg}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L154) are not escaped as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Posted by etzelc <gi...@git.apache.org>.
Github user etzelc commented on the issue:
https://github.com/apache/maven/pull/128
I will have a closer look next week, right now only tested with Windows (since only cmd script was modified). In the {{mvn}} script the string of the {{echo}} is already completely in double quotes, but I will have a look.
I have already an IT with three tests (for space, bracket and ampersand), but found out that maven has problems with ampersands in folder names. Probably I will remove that special case. See https://github.com/etzelc/maven-integration-testing/tree/MNG-6256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Posted by etzelc <gi...@git.apache.org>.
Github user etzelc commented on the issue:
https://github.com/apache/maven/pull/128
Now in `mvn.cmd` the string parameter of the echo command is surrounded with double quotes, like in `mvn`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org