You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Andreas Veithen (Created) (JIRA)" <ji...@apache.org> on 2012/02/26 18:08:51 UTC
[jira] [Created] (AXIOM-411) addChild doesn't work as expected when
invoked on a element that is already the parent of the node to be added
addChild doesn't work as expected when invoked on a element that is already the parent of the node to be added
--------------------------------------------------------------------------------------------------------------
Key: AXIOM-411
URL: https://issues.apache.org/jira/browse/AXIOM-411
Project: Axiom
Issue Type: Bug
Components: LLOM
Affects Versions: 1.2.12
Reporter: Andreas Veithen
Assignee: Andreas Veithen
Fix For: 1.2.13
When addChild is use to add a node to an element that is already the parent of that node, the expected result is that the node is moved to the end of the list of children of the element. However, this doesn't work (with LLOM; DOOM has not been tested). There are two cases:
1. The element is completely built. In that case, the children after the node are removed. This issue was first described in [1].
2. The element is not complete and the node is the last child that was instantiated. In that case, the addChild method is a no-op.
[1] http://mail-archives.apache.org/mod_mbox/ws-dev/201202.mbox/%3CCADg9GQZyX3dUFf%2BG0ED08hjsuxVMrTYViJ0ZE5uAjWCZEhr2fA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Resolved] (AXIOM-411) addChild doesn't work as expected
when invoked on a element that is already the parent of the node to be
added
Posted by "Andreas Veithen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIOM-411.
-----------------------------------
Resolution: Fixed
> addChild doesn't work as expected when invoked on a element that is already the parent of the node to be added
> --------------------------------------------------------------------------------------------------------------
>
> Key: AXIOM-411
> URL: https://issues.apache.org/jira/browse/AXIOM-411
> Project: Axiom
> Issue Type: Bug
> Components: DOOM, LLOM
> Affects Versions: 1.2.12
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.2.13
>
>
> When addChild is use to add a node to an element that is already the parent of that node, the expected result is that the node is moved to the end of the list of children of the element. However, this doesn't work (with LLOM; DOOM has not been tested). There are two cases:
> 1. The element is completely built. In that case, the children after the node are removed. This issue was first described in [1].
> 2. The element is not complete and the node is the last child that was instantiated. In that case, the addChild method is a no-op.
> [1] http://mail-archives.apache.org/mod_mbox/ws-dev/201202.mbox/%3CCADg9GQZyX3dUFf%2BG0ED08hjsuxVMrTYViJ0ZE5uAjWCZEhr2fA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-411) addChild doesn't work as expected
when invoked on a element that is already the parent of the node to be
added
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217507#comment-13217507 ]
Hudson commented on AXIOM-411:
------------------------------
Integrated in ws-axiom-trunk #802 (See [https://builds.apache.org/job/ws-axiom-trunk/802/])
AXIOM-411: Fixed multiple issues in addChild when used to add a node to an element that it is already a child of. This change also fixes an issue in DOOM's Node#removeChild. (Revision 1294297)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/OMDOMImplementationTest.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMDOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/dom
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/dom/TestRemoveChildIncomplete.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestAddChildWithSameParent.java
> addChild doesn't work as expected when invoked on a element that is already the parent of the node to be added
> --------------------------------------------------------------------------------------------------------------
>
> Key: AXIOM-411
> URL: https://issues.apache.org/jira/browse/AXIOM-411
> Project: Axiom
> Issue Type: Bug
> Components: DOOM, LLOM
> Affects Versions: 1.2.12
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.2.13
>
>
> When addChild is use to add a node to an element that is already the parent of that node, the expected result is that the node is moved to the end of the list of children of the element. However, this doesn't work (with LLOM; DOOM has not been tested). There are two cases:
> 1. The element is completely built. In that case, the children after the node are removed. This issue was first described in [1].
> 2. The element is not complete and the node is the last child that was instantiated. In that case, the addChild method is a no-op.
> [1] http://mail-archives.apache.org/mod_mbox/ws-dev/201202.mbox/%3CCADg9GQZyX3dUFf%2BG0ED08hjsuxVMrTYViJ0ZE5uAjWCZEhr2fA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Updated] (AXIOM-411) addChild doesn't work as expected when
invoked on a element that is already the parent of the node to be added
Posted by "Andreas Veithen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen updated AXIOM-411:
----------------------------------
Component/s: DOOM
DOOM is affected by the second issue because of an problem in the implementation of Node#removeChild.
> addChild doesn't work as expected when invoked on a element that is already the parent of the node to be added
> --------------------------------------------------------------------------------------------------------------
>
> Key: AXIOM-411
> URL: https://issues.apache.org/jira/browse/AXIOM-411
> Project: Axiom
> Issue Type: Bug
> Components: DOOM, LLOM
> Affects Versions: 1.2.12
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.2.13
>
>
> When addChild is use to add a node to an element that is already the parent of that node, the expected result is that the node is moved to the end of the list of children of the element. However, this doesn't work (with LLOM; DOOM has not been tested). There are two cases:
> 1. The element is completely built. In that case, the children after the node are removed. This issue was first described in [1].
> 2. The element is not complete and the node is the last child that was instantiated. In that case, the addChild method is a no-op.
> [1] http://mail-archives.apache.org/mod_mbox/ws-dev/201202.mbox/%3CCADg9GQZyX3dUFf%2BG0ED08hjsuxVMrTYViJ0ZE5uAjWCZEhr2fA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org