You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/01 21:26:44 UTC
Re: Review Request 67933: Replaced `` with
`` in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67933/#review206761
-----------------------------------------------------------
This was trivial and Windows only so I shipped it.
- Andrew Schwartzmeyer
On July 16, 2018, 2:43 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67933/
> -----------------------------------------------------------
>
> (Updated July 16, 2018, 2:43 p.m.)
>
>
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The intent is that `os.hpp` includes the correct OS-specific header,
> `windows/os.hpp` or `posix/os.hpp`, automatically. They should never
> be included manually.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/kill.hpp bd944357bd741d62aea78c839d87b80853e4a852
> 3rdparty/stout/include/stout/os/windows/rm.hpp 1c66e3e6fa20116866842378077e10052c147289
> 3rdparty/stout/include/stout/windows/net.hpp d70f967773d23672f53dd7dd6123434f5e81eeb0
>
>
> Diff: https://reviews.apache.org/r/67933/diff/1/
>
>
> Testing
> -------
>
> Old patch I found on my computer that I figured I should post. `ninja tests ; ctest -V` on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>