You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by ArvindSridhar <gi...@git.apache.org> on 2018/08/14 18:57:16 UTC
[GitHub] madlib pull request #311: Vector to columns: added support for splitting arr...
GitHub user ArvindSridhar opened a pull request:
https://github.com/apache/madlib/pull/311
Vector to columns: added support for splitting arrays of different lengths
Added support to split arrays of different lengths in the vector_col. If
the user does not provide feature names, we pad each array to the
maximum length and split across the maximum possible number of features.
If the user does provide feature names, we truncate/pad the arrays
according to the number of features the user desires. Added dev-check
tests and removed unit test to incorporate this change.
Co-authored-by: Rahul Iyer <ri...@apache.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/vec2colsarraybug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit f53e182e4378c07a7459bb1722d594fa335a52de
Author: Arvind Sridhar <ar...@...>
Date: 2018-08-14T18:37:40Z
Vector to columns: added support for splitting arrays of different lengths
Added support to split arrays of different lengths in the vector_col. If
the user does not provide feature names, we pad each array to the
maximum length and split across the maximum possible number of features.
If the user does provide feature names, we truncate/pad the arrays
according to the number of features the user desires. Added dev-check
tests and removed unit test to incorporate this change.
Co-authored-by: Rahul Iyer <ri...@apache.org>
----
---
[GitHub] madlib issue #311: Vector to columns: added support for splitting arrays of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/311
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/655/
---
[GitHub] madlib issue #311: Vector to columns: added support for splitting arrays of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/311
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/651/
---
[GitHub] madlib pull request #311: Vector to columns: added support for splitting arr...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/311#discussion_r210687181
--- Diff: src/ports/postgres/modules/utilities/test/unit_tests/test_transform_vec_cols.py_in ---
@@ -125,23 +125,24 @@ class Vec2ColsTestSuite(unittest.TestCase):
def test_get_names_for_split_output_cols_feature_names_none(self):
self.plpy_mock_execute.return_value = [{"n_x": 3}]
- new_cols = self.subject.get_names_for_split_output_cols(self.default_source_table, 'foobar', None)
+ new_cols = self.subject.get_names_for_split_output_cols(self.default_source_table, 'foobar')
self.assertEqual(['f1', 'f2', 'f3'], new_cols)
- def test_get_names_for_split_output_cols_feature_names_not_none(self):
- self.plpy_mock_execute.return_value = [{"n_x": 3}]
- new_cols = self.subject.get_names_for_split_output_cols(self.default_source_table, 'foobar', ['a', 'b', 'c'])
- self.assertEqual(['a', 'b', 'c'], new_cols)
+ # def test_get_names_for_split_output_cols_feature_names_not_none(self):
--- End diff --
We should remove these commented lines.
---
[GitHub] madlib pull request #311: Vector to columns: added support for splitting arr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/311
---