You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/09/11 02:30:47 UTC
[PR] fix(runtime-host): make managed WSL recovery actionable [maka]
me2seeks opened a new pull request, #5175:
URL: https://github.com/apache/maka/pull/5175
The managed WSL handoff added by #5161 can reach its explicit Desktop action, but the update command runs in `/bin/sh` without the user login environment. A WSL installation whose Node/npm is provided by mise, nvm, or shell initialization therefore fails deterministically with `npx: not found`, even though initial setup succeeded. The failure surface then suggests retrying and the source TUI sends the user back to Desktop, leaving no executable recovery path.
This change:
- runs WSL setup and update through the same current user login environment, using `$SHELL` rather than a recorded or hard-coded Node installation;
- keeps package replacement, active-work interruption consent, deployment/Host fences, and the no-downgrade rule unchanged;
- gives source TUI users the concrete Desktop handoff action when Desktop owns the deployment;
- shows a validated development package version in Desktop instead of a SHA-512 integrity value, with a human fallback when no display version is available; and
- makes a failed handoff direct the user to its diagnostic instead of implying unchanged retries will repair it.
The WSL setup/update shell behavior was also reproduced against an installation where a noninteractive shell cannot find `npx`, while the user login shell resolves the current mise-managed Node/npm successfully.
Refs #5143
Follow-up to #5161
Validation:
- `npm run rebuild`
- `npm run typecheck`
- `npm run lint`
- `npm run format:check`
- 58 focused Runtime Host, CLI, setup-package, WSL controller, and WSL handoff tests
- `npm run check:stale`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(runtime-host): make managed WSL recovery actionable [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5175:
URL: https://github.com/apache/maka/pull/5175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org