You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/23 22:12:16 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #2397: rebase cnd branch with master
BradWalker opened a new pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397
The CND module code branch has not been updated recently with a rebase from master.. This needs to be done to keep things somewhat current.
That's what I've done here.
As for testing, it builds and runs correctly. The C/C++ module is activated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2397: rebase cnd branch with master
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397#issuecomment-701142041
I would incline to a merge (rather than a rebase) as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2397: rebase cnd branch with master
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397#issuecomment-700859149
I have mixed feelings here. In general I prefer rebases, but that are cases where a single author creates a PR. In this case the development of the CND branch is separated from master, but runs in parallel.
It depends on what we envision as "end-game". What I mean, what happens when we what to get this to master. If we agree, that a plain merge is ok, then I would merge master into cnd. If we want to keep cnd more separate a rebase would be more logical. I looked at this PR and have some doubts, that we gain much by a rebase.
I think merging master might be the better option. @jlahoda what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker closed pull request #2397: rebase cnd branch with master
Posted by GitBox <gi...@apache.org>.
BradWalker closed pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2397: rebase cnd branch with master
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397#issuecomment-950338408
@BradWalker should this be kept open or closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2397: rebase cnd branch with master
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2397:
URL: https://github.com/apache/netbeans/pull/2397#issuecomment-710137711
Shall we close this PR then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists