You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2024/08/26 10:55:20 UTC

[PR] Fix some non-critical pre-commit issues [airflow]

uranusjr opened a new pull request, #41749:
URL: https://github.com/apache/airflow/pull/41749

   I was running `pre-commit run -a` to fix some conflicts on database migration and found some interesting pre-commit failures that only occur in edge cases. Nothing serious, let’s just fix them. I don’t think any of these are common enough to require new checks.
   
   The '.venv' name (common for in-project virtual environments) is not included in rat-excludes, causing a lint failure since a license is not found in it. Since 'venv' (no leading dot) is excluded, let's also add '.venv' to the file.
   
   The 'downgradedb' method of BaseDBManager is declared abstract, but not implemented in FABDBManager. This causes Mypy to error when FABDBManager is instantiated. We don't always need the implement the method, so let's remove the abstractmethod decorator.
   
   Finally (and least critically), when you run pre-commit during a merge, a hook checks if you're committing unresolved conflicts. The check is not particularly smart, however, and can mis-identify header underlines in restructuredText as false positives. This is easy to fix; just add one more character to the underline. It's fine as long as the underline is not EXACTLY SEVEN characters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix some non-critical pre-commit issues [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #41749:
URL: https://github.com/apache/airflow/pull/41749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org