You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/26 20:44:38 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
shinrich opened a new pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631
Noticed this while reviewing PR #7622. There was a change in HttpSessionManager::acquireSession that seemed unrelated to the H2 to origin changes. Plus the version on master seemed old.
A little time with "git blame" got me to PR #6828. That PR had been open for quite a while. I assume that @a-canary made a rebase error when getting the PR ready to land. This is the change that was in PR #7622 and is what we are running with in our 9.0.x based production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631#issuecomment-809633889
I assume we don't need this for 9.0.x ?
Cherry-picked to 9.1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631#issuecomment-809395055
Looks like the pool thread scheduling autest error was transient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631#issuecomment-808670384
No approval at the moment since autest failed, but looks reasonable. This is basically restoring a part of code from #6805.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7631: Fix HttpSessionManager::acquireSession from previous rebase error
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7631:
URL: https://github.com/apache/trafficserver/pull/7631#issuecomment-809371760
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org