You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2018/04/27 13:47:18 UTC
[GitHub] carbondata pull request #2243: [CARBONDATA-2410] Error message correction wh...
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/2243
[CARBONDATA-2410] Error message correction when column value length exceeds 320000 character
The raw is displayed in the client, to avoid the same the exception message is intercepted and sent back to driver.…
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
None
- [X] Any backward compatibility impacted?
None
- [X] Document update required?
None
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
None
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
None
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata message_correction
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2243
----
----
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/2243
retest this please
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5473/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5495/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
In CSVInputFormat.java class set the error content length to 0 in parser setting so that parser while preparing the exception message does not contain the data on the error message.
Method: extractCsvParserSettings
parserSettings.setErrorContentLength(0);
Give this 0 a meaning name as constant and also write the comment before setting the error content length to describe its purpose
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2243
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4674/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4306/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4362/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/2243
Failled test is unrelated
---
[GitHub] carbondata pull request #2243: [CARBONDATA-2410] Error message correction wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2243
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5530/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
Can we add a test case for this scenario
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5578/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2243
@mohammadshahidkhan , can you please add details on why we have to change the exception parsing now.. Did we change univocity jar recently?
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4420/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2243
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4628/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
LGTM
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5526/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4366/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/2243
restricted parsed data display in the exception using parserSettings.setErrorContentLength(0)
---
[GitHub] carbondata pull request #2243: [CARBONDATA-2410] Error message correction wh...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2243#discussion_r184991452
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
@@ -824,9 +824,11 @@ object GlobalDictionaryUtil {
def trimErrorMessage(input: String): String = {
var errorMessage: String = null
if (input != null && input.contains("TextParsingException:")) {
- if (input.split("Hint").length > 0 &&
+ if (input.split("Hint").length > 1 &&
--- End diff --
The title of the fix is wrong.. It should be 32000 characters
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2243
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4597/
---
[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2243
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4329/
---