Pull request for NIFI-1207

[Gavin Leithall <gl...@caci.co.uk>]

Hi,

I raised a pull request for NIFI-1207 last week (https://github.com/apache/nifi/pull/4467).

I confirmed most the of the PR checks (squashing commits being the most notable exception) - is there anything you would like me to do before it can be reviewed?

Best regards,
Gavin
This electronic message contains information from CACI International Inc or
subsidiary companies, which may be confidential, proprietary,
privileged or otherwise protected from disclosure.  The information is
intended to be used solely by the recipient(s) named above.  If you are not
an intended recipient, be aware that any review, disclosure, copying,
distribution or use of this transmission or its contents is prohibited.  If
you have received this transmission in error, please notify us immediately
at postmaster@caci.co.uk
Viruses: Although we have taken steps to ensure that this e-mail and 
attachments are free from any virus, we advise that in keeping with good 
computing practice the recipient should ensure they are actually virus free.

CACI Limited. Registered in England & Wales. Registration No. 1649776. CACI House, Avonmore Road, London, W14 8TS

RE: Pull request for NIFI-1207

[Gavin Leithall <gl...@caci.co.uk>]

Sorry, this is now https://github.com/apache/nifi/pull/4484

I messed up the changes.

Best regards,
Gavin

From: Gavin Leithall
Sent: 18 August 2020 17:07
To: dev@nifi.apache.org
Subject: Pull request for NIFI-1207

Hi,

I raised a pull request for NIFI-1207 last week (https://github.com/apache/nifi/pull/4467).

I confirmed most the of the PR checks (squashing commits being the most notable exception) - is there anything you would like me to do before it can be reviewed?

Best regards,
Gavin
This electronic message contains information from CACI International Inc or
subsidiary companies, which may be confidential, proprietary,
privileged or otherwise protected from disclosure.  The information is
intended to be used solely by the recipient(s) named above.  If you are not
an intended recipient, be aware that any review, disclosure, copying,
distribution or use of this transmission or its contents is prohibited.  If
you have received this transmission in error, please notify us immediately
at postmaster@caci.co.uk
Viruses: Although we have taken steps to ensure that this e-mail and 
attachments are free from any virus, we advise that in keeping with good 
computing practice the recipient should ensure they are actually virus free.

CACI Limited. Registered in England & Wales. Registration No. 1649776. CACI House, Avonmore Road, London, W14 8TS

Re: Pull request for NIFI-1207

[Pierre Villard <pi...@gmail.com>]

Hi Gavin,

Can you rebase and squash your commits into one single commit for your pull
request? (you may want to do it after 1.12.0 is released, which should
happen today or tomorrow so that you can update the reference to
1.13.0-SNAPSHOT)

Then there are a few things that should be changed: the processor should
have the same version as what is in master and all the dependencies to NiFi
should use what is available in master (currently 1.12.0-SNAPSHOT but soon
1.13.0-SNAPSHOT)

Then I'd suggest ways for reviewers to test your pull request. Do you have
any suggestions for Docker containers/images that could be used to test
your pull request? Anything you can provide to help people will greatly
increase the chances for a faster review.

You may also want to have a look at the contributor guide [1].

Thanks,
Pierre

[1] https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide

Le mar. 18 août 2020 à 18:23, Gavin Leithall <gl...@caci.co.uk> a
écrit :

> Hi,
>
> I raised a pull request for NIFI-1207 last week (
> https://github.com/apache/nifi/pull/4467).
>
> I confirmed most the of the PR checks (squashing commits being the most
> notable exception) - is there anything you would like me to do before it
> can be reviewed?
>
> Best regards,
> Gavin
> This electronic message contains information from CACI International Inc or
> subsidiary companies, which may be confidential, proprietary,
> privileged or otherwise protected from disclosure.  The information is
> intended to be used solely by the recipient(s) named above.  If you are not
> an intended recipient, be aware that any review, disclosure, copying,
> distribution or use of this transmission or its contents is prohibited.  If
> you have received this transmission in error, please notify us immediately
> at postmaster@caci.co.uk
> Viruses: Although we have taken steps to ensure that this e-mail and
> attachments are free from any virus, we advise that in keeping with good
> computing practice the recipient should ensure they are actually virus
> free.
>
> CACI Limited. Registered in England & Wales. Registration No. 1649776.
> CACI House, Avonmore Road, London, W14 8TS
>