[GitHub] [drill] Ben-Zvi commented on a change in pull request #1650: DRILL-6707: Allow Merge-Join batch resizing to go smaller than current outgoing row count

[GitBox <gi...@apache.org>]

Ben-Zvi commented on a change in pull request #1650: DRILL-6707: Allow Merge-Join batch resizing to go smaller than current outgoing row count
URL: https://github.com/apache/drill/pull/1650#discussion_r265365371
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
 ##########
 @@ -124,7 +124,8 @@
      */
     @Override
     public void update(int inputIndex) {
-      status.setTargetOutputRowCount(super.update(inputIndex, status.getOutPosition()));
+      super.update(inputIndex, status.getOutPosition());
+      status.setTargetOutputRowCount(super.getCurrentOutgoingMaxRowCount());
 
 Review comment:
   Like the other joins, add a comment: // calculated by update() 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services