You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/11 19:34:23 UTC

[GitHub] [commons-vfs] garydgregory commented on a change in pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times

garydgregory commented on a change in pull request #82:
URL: https://github.com/apache/commons-vfs/pull/82#discussion_r487249867



##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java
##########
@@ -69,5 +69,20 @@ default void setBufferSize(final int bufferSize) throws FileSystemException {
     }
 
     OutputStream storeFileStream(String relPath) throws IOException;
-
+    
+    /**
+     * @since 2.7.0
+     */
+    default boolean getRemoteFtpFeatures() throws IOException {
+        // Backward compatibility: return false ("FEAT" not supported)
+        return false;
+    }
+    
+    /**
+     * @since 2.7.0
+     */
+    default FTPFile mdtmFile(final String relPath) throws IOException {
+        // Backward compatibility: return empty FTPFile
+        return new FTPFile();

Review comment:
       This seems misleading. Why not return `null` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org