You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Emilian Bold <em...@gmail.com> on 2017/10/08 10:18:52 UTC
#Hacktoberfest : Please check with the existing #Hacktoberfest issues
before making a PR
Hello,
I am trying to keep in sync the #Hacktoberfest issues on
https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
.
Since I have to do this manually and PRs happen even during the night I am
getting out of sync sometimes and then I notice that we have 2 PRs for the
same module.
So, please try to help out with the #Hacktoberfest issue by commenting on
the issues and PRs. Or, at least, make sure your module doesn't already
have a PR open!
The way I see it, #Hacktoberfest is a good chance to bring in new people
into the community and gain some good will so it must be a downer for some
new contributor to see me reject his/her PR because somebody else beat him
to it.
PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
superior to the wiki. With a bit more structure we could have *generated*
the review based on commit comments alone.
--emi
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest
issues before making a PR
Posted by Antonio <an...@vieiro.net>.
Mmmm... I don't think it's a good idea.
I think Hacktoberfest is a great idea and widens the awareness of the
project and the sense of participation. Those are Good Thinks, IMHO.
Let's assume someone chooses libs.jaxb, for instance. That has an
external directory to be reviewed. If the participant does not want to
review the external directory stuff then just let him commit to your
repository and tell me.
I will then open a branch in my repository and will let you make a pull
request against that branch, so I'll review the external directory, add
the maven stuff, and then will submit to Apache's.
Does that make sense?
Un abrazo,
Antonio
On 08/10/17 13:29, Emilian Bold wrote:
> I'll write some new scripts later today and auto-close some issues.
>
> --emi
>
> Pe 8 oct. 2017, la 14:10, Antonio <an...@vieiro.net> a scris:
>
>> Hi again,
>>
>> That being so I'd suggest removing from the #Hacktoberfest the modules containing an "external" directory, because those will have to be reviewed again for checking binaries and adding maven coordinates.
>>
>> Un abrazo,
>> Antonio
>>
>>> On 08/10/17 12:52, Emilian Bold wrote:
>>> #Hacktoberfest contributors will only change the license headers, add
>>> exclusions and other smaller tweaks. They won't generally review 3rd party
>>> dependencies.
>>> I know it seems duplicate but the whole point is to avoid sending people to
>>> the wiki which is intimidating.
>>> Using only GitHub is enough and frankly much simpler. We should have been
>>> using issues instead of the wiki -- it's really annoying to scroll down in
>>> order to find a given module!
>>> I generated the issues automatically based on `ant rat`. I guess I need
>>> another script to see what to automatically close based on the current `ant
>>> rat` output.
>>> Too bad the wiki is not easily parseable, but being HTML it might be
>>> doable, because I could also sync-up reservations (which don't yet impact
>>> `ant rat` output).
>>> --emi
>>>> On Sun, Oct 8, 2017 at 1:44 PM, Antonio <an...@vieiro.net> wrote:
>>>> Hi again,
>>>>
>>>> Another idea: choose an hour (and a timezone) for adding #Hackoberfest
>>>> entries to the list of modules to review, and we'll reserve modules
>>>> afterwards. This is probably easier.
>>>>
>>>> Otro abrazo,
>>>> Antonio
>>>>
>>>>
>>>>> On 08/10/17 12:32, Antonio Vieiro wrote:
>>>>>
>>>>> This is duplicating efforts, Emilian, I think.
>>>>>
>>>>> What about this?
>>>>>
>>>>> - You reserve whatever modules for review in the “List of Modules to
>>>>> Review” and add a #Hacktoberfest tag there.
>>>>> - You tell #Hacktoberfest volunteers to read the “List of Modules to
>>>>> Review” and to choose any module with the #Hacktoberfest tag.
>>>>>
>>>>> The key idea is to have a single list of modules to be reviewed, and not
>>>>> two.
>>>>>
>>>>> Un abrazo,
>>>>> Antonio
>>>>>
>>>>> P.S.:
>>>>>
>>>>> https://github.com/emilianbold/incubator-netbeans/pull/259 for
>>>>> libs.jaxb, for instance, is missing the external/binaries_list review
>>>>> (three jar entries with maven coordinates and a javadoc-zip file there with
>>>>> the coordinates Matthias suggests in another email).
>>>>>
>>>>> I’ll mark this module as a #Hacktoberfest in the "list of modules for
>>>>> review" and move along with another module.
>>>>>
>>>>>
>>>>> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com>
>>>>>> escribió:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> I am trying to keep in sync the #Hacktoberfest issues on
>>>>>> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/List+
>>>>>> of+Modules+to+Review
>>>>>> .
>>>>>>
>>>>>> Since I have to do this manually and PRs happen even during the night I
>>>>>> am
>>>>>> getting out of sync sometimes and then I notice that we have 2 PRs for
>>>>>> the
>>>>>> same module.
>>>>>>
>>>>>> So, please try to help out with the #Hacktoberfest issue by commenting on
>>>>>> the issues and PRs. Or, at least, make sure your module doesn't already
>>>>>> have a PR open!
>>>>>>
>>>>>> The way I see it, #Hacktoberfest is a good chance to bring in new people
>>>>>> into the community and gain some good will so it must be a downer for
>>>>>> some
>>>>>> new contributor to see me reject his/her PR because somebody else beat
>>>>>> him
>>>>>> to it.
>>>>>>
>>>>>> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
>>>>>> superior to the wiki. With a bit more structure we could have *generated*
>>>>>> the review based on commit comments alone.
>>>>>>
>>>>>> --emi
>>>>>>
>>>>>
>>>>>
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest issues before making a PR
Posted by Emilian Bold <em...@gmail.com>.
I'll write some new scripts later today and auto-close some issues.
--emi
Pe 8 oct. 2017, la 14:10, Antonio <an...@vieiro.net> a scris:
> Hi again,
>
> That being so I'd suggest removing from the #Hacktoberfest the modules containing an "external" directory, because those will have to be reviewed again for checking binaries and adding maven coordinates.
>
> Un abrazo,
> Antonio
>
>> On 08/10/17 12:52, Emilian Bold wrote:
>> #Hacktoberfest contributors will only change the license headers, add
>> exclusions and other smaller tweaks. They won't generally review 3rd party
>> dependencies.
>> I know it seems duplicate but the whole point is to avoid sending people to
>> the wiki which is intimidating.
>> Using only GitHub is enough and frankly much simpler. We should have been
>> using issues instead of the wiki -- it's really annoying to scroll down in
>> order to find a given module!
>> I generated the issues automatically based on `ant rat`. I guess I need
>> another script to see what to automatically close based on the current `ant
>> rat` output.
>> Too bad the wiki is not easily parseable, but being HTML it might be
>> doable, because I could also sync-up reservations (which don't yet impact
>> `ant rat` output).
>> --emi
>>> On Sun, Oct 8, 2017 at 1:44 PM, Antonio <an...@vieiro.net> wrote:
>>> Hi again,
>>>
>>> Another idea: choose an hour (and a timezone) for adding #Hackoberfest
>>> entries to the list of modules to review, and we'll reserve modules
>>> afterwards. This is probably easier.
>>>
>>> Otro abrazo,
>>> Antonio
>>>
>>>
>>>> On 08/10/17 12:32, Antonio Vieiro wrote:
>>>>
>>>> This is duplicating efforts, Emilian, I think.
>>>>
>>>> What about this?
>>>>
>>>> - You reserve whatever modules for review in the “List of Modules to
>>>> Review” and add a #Hacktoberfest tag there.
>>>> - You tell #Hacktoberfest volunteers to read the “List of Modules to
>>>> Review” and to choose any module with the #Hacktoberfest tag.
>>>>
>>>> The key idea is to have a single list of modules to be reviewed, and not
>>>> two.
>>>>
>>>> Un abrazo,
>>>> Antonio
>>>>
>>>> P.S.:
>>>>
>>>> https://github.com/emilianbold/incubator-netbeans/pull/259 for
>>>> libs.jaxb, for instance, is missing the external/binaries_list review
>>>> (three jar entries with maven coordinates and a javadoc-zip file there with
>>>> the coordinates Matthias suggests in another email).
>>>>
>>>> I’ll mark this module as a #Hacktoberfest in the "list of modules for
>>>> review" and move along with another module.
>>>>
>>>>
>>>> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com>
>>>>> escribió:
>>>>>
>>>>> Hello,
>>>>>
>>>>> I am trying to keep in sync the #Hacktoberfest issues on
>>>>> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/List+
>>>>> of+Modules+to+Review
>>>>> .
>>>>>
>>>>> Since I have to do this manually and PRs happen even during the night I
>>>>> am
>>>>> getting out of sync sometimes and then I notice that we have 2 PRs for
>>>>> the
>>>>> same module.
>>>>>
>>>>> So, please try to help out with the #Hacktoberfest issue by commenting on
>>>>> the issues and PRs. Or, at least, make sure your module doesn't already
>>>>> have a PR open!
>>>>>
>>>>> The way I see it, #Hacktoberfest is a good chance to bring in new people
>>>>> into the community and gain some good will so it must be a downer for
>>>>> some
>>>>> new contributor to see me reject his/her PR because somebody else beat
>>>>> him
>>>>> to it.
>>>>>
>>>>> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
>>>>> superior to the wiki. With a bit more structure we could have *generated*
>>>>> the review based on commit comments alone.
>>>>>
>>>>> --emi
>>>>>
>>>>
>>>>
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest
issues before making a PR
Posted by Antonio <an...@vieiro.net>.
Hi again,
That being so I'd suggest removing from the #Hacktoberfest the modules
containing an "external" directory, because those will have to be
reviewed again for checking binaries and adding maven coordinates.
Un abrazo,
Antonio
On 08/10/17 12:52, Emilian Bold wrote:
> #Hacktoberfest contributors will only change the license headers, add
> exclusions and other smaller tweaks. They won't generally review 3rd party
> dependencies.
>
> I know it seems duplicate but the whole point is to avoid sending people to
> the wiki which is intimidating.
>
> Using only GitHub is enough and frankly much simpler. We should have been
> using issues instead of the wiki -- it's really annoying to scroll down in
> order to find a given module!
>
> I generated the issues automatically based on `ant rat`. I guess I need
> another script to see what to automatically close based on the current `ant
> rat` output.
>
> Too bad the wiki is not easily parseable, but being HTML it might be
> doable, because I could also sync-up reservations (which don't yet impact
> `ant rat` output).
>
>
>
>
> --emi
>
> On Sun, Oct 8, 2017 at 1:44 PM, Antonio <an...@vieiro.net> wrote:
>
>> Hi again,
>>
>> Another idea: choose an hour (and a timezone) for adding #Hackoberfest
>> entries to the list of modules to review, and we'll reserve modules
>> afterwards. This is probably easier.
>>
>> Otro abrazo,
>> Antonio
>>
>>
>> On 08/10/17 12:32, Antonio Vieiro wrote:
>>
>>> This is duplicating efforts, Emilian, I think.
>>>
>>> What about this?
>>>
>>> - You reserve whatever modules for review in the “List of Modules to
>>> Review” and add a #Hacktoberfest tag there.
>>> - You tell #Hacktoberfest volunteers to read the “List of Modules to
>>> Review” and to choose any module with the #Hacktoberfest tag.
>>>
>>> The key idea is to have a single list of modules to be reviewed, and not
>>> two.
>>>
>>> Un abrazo,
>>> Antonio
>>>
>>> P.S.:
>>>
>>> https://github.com/emilianbold/incubator-netbeans/pull/259 for
>>> libs.jaxb, for instance, is missing the external/binaries_list review
>>> (three jar entries with maven coordinates and a javadoc-zip file there with
>>> the coordinates Matthias suggests in another email).
>>>
>>> I’ll mark this module as a #Hacktoberfest in the "list of modules for
>>> review" and move along with another module.
>>>
>>>
>>> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com>
>>>> escribió:
>>>>
>>>> Hello,
>>>>
>>>> I am trying to keep in sync the #Hacktoberfest issues on
>>>> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/List+
>>>> of+Modules+to+Review
>>>> .
>>>>
>>>> Since I have to do this manually and PRs happen even during the night I
>>>> am
>>>> getting out of sync sometimes and then I notice that we have 2 PRs for
>>>> the
>>>> same module.
>>>>
>>>> So, please try to help out with the #Hacktoberfest issue by commenting on
>>>> the issues and PRs. Or, at least, make sure your module doesn't already
>>>> have a PR open!
>>>>
>>>> The way I see it, #Hacktoberfest is a good chance to bring in new people
>>>> into the community and gain some good will so it must be a downer for
>>>> some
>>>> new contributor to see me reject his/her PR because somebody else beat
>>>> him
>>>> to it.
>>>>
>>>> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
>>>> superior to the wiki. With a bit more structure we could have *generated*
>>>> the review based on commit comments alone.
>>>>
>>>> --emi
>>>>
>>>
>>>
>
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest
issues before making a PR
Posted by Emilian Bold <em...@gmail.com>.
#Hacktoberfest contributors will only change the license headers, add
exclusions and other smaller tweaks. They won't generally review 3rd party
dependencies.
I know it seems duplicate but the whole point is to avoid sending people to
the wiki which is intimidating.
Using only GitHub is enough and frankly much simpler. We should have been
using issues instead of the wiki -- it's really annoying to scroll down in
order to find a given module!
I generated the issues automatically based on `ant rat`. I guess I need
another script to see what to automatically close based on the current `ant
rat` output.
Too bad the wiki is not easily parseable, but being HTML it might be
doable, because I could also sync-up reservations (which don't yet impact
`ant rat` output).
--emi
On Sun, Oct 8, 2017 at 1:44 PM, Antonio <an...@vieiro.net> wrote:
> Hi again,
>
> Another idea: choose an hour (and a timezone) for adding #Hackoberfest
> entries to the list of modules to review, and we'll reserve modules
> afterwards. This is probably easier.
>
> Otro abrazo,
> Antonio
>
>
> On 08/10/17 12:32, Antonio Vieiro wrote:
>
>> This is duplicating efforts, Emilian, I think.
>>
>> What about this?
>>
>> - You reserve whatever modules for review in the “List of Modules to
>> Review” and add a #Hacktoberfest tag there.
>> - You tell #Hacktoberfest volunteers to read the “List of Modules to
>> Review” and to choose any module with the #Hacktoberfest tag.
>>
>> The key idea is to have a single list of modules to be reviewed, and not
>> two.
>>
>> Un abrazo,
>> Antonio
>>
>> P.S.:
>>
>> https://github.com/emilianbold/incubator-netbeans/pull/259 for
>> libs.jaxb, for instance, is missing the external/binaries_list review
>> (three jar entries with maven coordinates and a javadoc-zip file there with
>> the coordinates Matthias suggests in another email).
>>
>> I’ll mark this module as a #Hacktoberfest in the "list of modules for
>> review" and move along with another module.
>>
>>
>> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com>
>>> escribió:
>>>
>>> Hello,
>>>
>>> I am trying to keep in sync the #Hacktoberfest issues on
>>> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
>>> https://cwiki.apache.org/confluence/display/NETBEANS/List+
>>> of+Modules+to+Review
>>> .
>>>
>>> Since I have to do this manually and PRs happen even during the night I
>>> am
>>> getting out of sync sometimes and then I notice that we have 2 PRs for
>>> the
>>> same module.
>>>
>>> So, please try to help out with the #Hacktoberfest issue by commenting on
>>> the issues and PRs. Or, at least, make sure your module doesn't already
>>> have a PR open!
>>>
>>> The way I see it, #Hacktoberfest is a good chance to bring in new people
>>> into the community and gain some good will so it must be a downer for
>>> some
>>> new contributor to see me reject his/her PR because somebody else beat
>>> him
>>> to it.
>>>
>>> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
>>> superior to the wiki. With a bit more structure we could have *generated*
>>> the review based on commit comments alone.
>>>
>>> --emi
>>>
>>
>>
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest
issues before making a PR
Posted by Antonio <an...@vieiro.net>.
Hi again,
Another idea: choose an hour (and a timezone) for adding #Hackoberfest
entries to the list of modules to review, and we'll reserve modules
afterwards. This is probably easier.
Otro abrazo,
Antonio
On 08/10/17 12:32, Antonio Vieiro wrote:
> This is duplicating efforts, Emilian, I think.
>
> What about this?
>
> - You reserve whatever modules for review in the “List of Modules to Review” and add a #Hacktoberfest tag there.
> - You tell #Hacktoberfest volunteers to read the “List of Modules to Review” and to choose any module with the #Hacktoberfest tag.
>
> The key idea is to have a single list of modules to be reviewed, and not two.
>
> Un abrazo,
> Antonio
>
> P.S.:
>
> https://github.com/emilianbold/incubator-netbeans/pull/259 for libs.jaxb, for instance, is missing the external/binaries_list review (three jar entries with maven coordinates and a javadoc-zip file there with the coordinates Matthias suggests in another email).
>
> I’ll mark this module as a #Hacktoberfest in the "list of modules for review" and move along with another module.
>
>
>> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com> escribió:
>>
>> Hello,
>>
>> I am trying to keep in sync the #Hacktoberfest issues on
>> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
>> https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
>> .
>>
>> Since I have to do this manually and PRs happen even during the night I am
>> getting out of sync sometimes and then I notice that we have 2 PRs for the
>> same module.
>>
>> So, please try to help out with the #Hacktoberfest issue by commenting on
>> the issues and PRs. Or, at least, make sure your module doesn't already
>> have a PR open!
>>
>> The way I see it, #Hacktoberfest is a good chance to bring in new people
>> into the community and gain some good will so it must be a downer for some
>> new contributor to see me reject his/her PR because somebody else beat him
>> to it.
>>
>> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
>> superior to the wiki. With a bit more structure we could have *generated*
>> the review based on commit comments alone.
>>
>> --emi
>
Re: #Hacktoberfest : Please check with the existing #Hacktoberfest
issues before making a PR
Posted by Antonio Vieiro <an...@vieiro.net>.
This is duplicating efforts, Emilian, I think.
What about this?
- You reserve whatever modules for review in the “List of Modules to Review” and add a #Hacktoberfest tag there.
- You tell #Hacktoberfest volunteers to read the “List of Modules to Review” and to choose any module with the #Hacktoberfest tag.
The key idea is to have a single list of modules to be reviewed, and not two.
Un abrazo,
Antonio
P.S.:
https://github.com/emilianbold/incubator-netbeans/pull/259 for libs.jaxb, for instance, is missing the external/binaries_list review (three jar entries with maven coordinates and a javadoc-zip file there with the coordinates Matthias suggests in another email).
I’ll mark this module as a #Hacktoberfest in the "list of modules for review" and move along with another module.
> El 8 oct 2017, a las 12:18, Emilian Bold <em...@gmail.com> escribió:
>
> Hello,
>
> I am trying to keep in sync the #Hacktoberfest issues on
> https://github.com/emilianbold/incubator-netbeans/issues and the wiki on
> https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
> .
>
> Since I have to do this manually and PRs happen even during the night I am
> getting out of sync sometimes and then I notice that we have 2 PRs for the
> same module.
>
> So, please try to help out with the #Hacktoberfest issue by commenting on
> the issues and PRs. Or, at least, make sure your module doesn't already
> have a PR open!
>
> The way I see it, #Hacktoberfest is a good chance to bring in new people
> into the community and gain some good will so it must be a downer for some
> new contributor to see me reject his/her PR because somebody else beat him
> to it.
>
> PS: Now that I'm doing this both ways, I believe GitHub issues + PRs is
> superior to the wiki. With a bit more structure we could have *generated*
> the review based on commit comments alone.
>
> --emi