[tinkerpop] 06/12: Fix for numbers not being translated correctly in the bytecode translator

[sp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch TINKERPOP-1959-tp33
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit a59780f7c09de57449aab606c32580455184a7b2
Author: Matthew Allen <ma...@runbox.com>
AuthorDate: Sat Sep 1 08:24:05 2018 +0100

    Fix for numbers not being translated correctly in the bytecode translator
---
 .../main/javascript/gremlin-javascript/lib/process/translator.js   | 2 ++
 .../javascript/gremlin-javascript/test/unit/translator-test.js     | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
index dfd4b69..32c58d7 100644
--- a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
+++ b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
@@ -75,6 +75,8 @@ class Translator {
             }
           } else if (params[k] === undefined) {
             script += '';
+          } else if (typeof params[k] === 'number') {
+            script += params[k];
           } else {
             script += '\'' + params[k] + '\'';
           }
diff --git a/gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/translator-test.js b/gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/translator-test.js
index b5310bf..f8d4396 100644
--- a/gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/translator-test.js
+++ b/gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/translator-test.js
@@ -37,6 +37,13 @@ describe('Translator', function () {
       assert.strictEqual(script, 'g.V().out(\'created\')');
     });
 
+    it('should produce valid script representation from bytecode glv steps translating number and text correctly', function () {
+      const g = new graph.Graph().traversal();
+      const script = new Translator('g').translate(g.V(1).out('created').getBytecode());
+      assert.ok(script);
+      assert.strictEqual(script, 'g.V(1).out(\'created\')');
+    });
+
     it('should produce valid script representation from bytecode glv steps containing parameter bindings', function () {
       const g = new graph.Graph().traversal();
       const script = new Translator('g').translate(g.addV({'name': 'Lilac'}).getBytecode());