[GitHub] [mynewt-core] utzig commented on pull request #2839: nrf5340: avoid have 2 interrupts for each IPC message

[GitBox <gi...@apache.org>]

utzig commented on PR #2839:
URL: https://github.com/apache/mynewt-core/pull/2839#issuecomment-1128463667

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
   <details>
   
   ```diff
   @@ -405,12 +405,14 @@
            /* assert since that will always fail for non-blocking write
             * indicating use error
             */
   -        if (space == 0) return SYS_ENOMEM;
   +        if (space == 0) {
   +            return SYS_ENOMEM;
   +        }
    #endif
        } while (space == 0);
    
        ipc_nrf5340_shm_write(shm, &data, 1);
   -    // dont notify other side! (will be done by later calls to ipc_nrf5340_send)
   +    /* dont notify other side! (will be done by later calls to ipc_nrf5340_send) */
    
        return 0;
    }
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org