You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/03/07 10:50:07 UTC
[PR] Fix log exception when FieldsMarker.visitedIndexes is empty [parquet-mr]
panbingkun opened a new pull request, #1294:
URL: https://github.com/apache/parquet-mr/pull/1294
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Style
- [ ] My contribution adheres to the code style guidelines and Spotless passes.
- To apply the necessary changes, run `mvn spotless:apply -Pvector-plugins`
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] Fix log exception when FieldsMarker.visitedIndexes is empty [parquet-mr]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #1294:
URL: https://github.com/apache/parquet-mr/pull/1294#issuecomment-1983284813
1.When `FieldsMarker.visitedIndexes`(`BitSet`) is `empty`, using log4j2 to output logs in `MessageColumnIORecordConsumer.printState` will produce unexpected exception log printing, as follows:
<img width="1015" alt="image" src="https://github.com/apache/parquet-mr/assets/15246973/0e68f86c-1250-4038-b224-951ff58ae493">
https://github.com/panbingkun/spark/actions/runs/8182167017/job/22373124743#step:12:4023
The root cause is that when the `BitSet is empty`, `BitSet.toString` will output `{}`, which will cause` log4j2` to go through the logic `performs placeholder substitution` when we call `log.debug(String format, Object... arguments)`, resulting in `unexpected logs` being printed in the log.
After discussions with the `log4j2 community`, we can avoid this situation by directly calling `log.debug(String msg)` under current circumstances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2445: Fix log exception when FieldsMarker.visitedIndexes is empty [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #1294:
URL: https://github.com/apache/parquet-mr/pull/1294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] Fix log exception when FieldsMarker.visitedIndexes is empty [parquet-mr]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #1294:
URL: https://github.com/apache/parquet-mr/pull/1294#issuecomment-1983310307
cc @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2445: Fix log exception when FieldsMarker.visitedIndexes is empty [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1294:
URL: https://github.com/apache/parquet-mr/pull/1294#issuecomment-1988687309
Thanks for the fix! @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org