[GitHub] [tez] abstractdog commented on a change in pull request #166: TEZ-4227 Introduce convenient methods in TezID subclasses

[GitBox <gi...@apache.org>]

abstractdog commented on a change in pull request #166:
URL: https://github.com/apache/tez/pull/166#discussion_r775143103



##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGSchedulerNaturalOrderControlled.java
##########
@@ -154,8 +154,7 @@ private void processDownstreamVertices(Vertex vertex) {
     List<Vertex> newlyScheduledVertices = Lists.newLinkedList();
     Map<Vertex, Edge> outputVertexEdgeMap = vertex.getOutputVertices();
     for (Vertex destVertex : outputVertexEdgeMap.keySet()) {
-      if (vertexAlreadyScheduled(destVertex)) { // Nothing to do if already scheduled.
-      } else {
+      if (!vertexAlreadyScheduled(destVertex)) { // Nothing to do if already scheduled.

Review comment:
       you can delete the comment "Nothing to do" from here as it corresponds to the deleted branch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org