[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #62: [flaky tests] Fix flaky ShutdownTest::testDestructor

[GitBox <gi...@apache.org>]

BewareMyPower opened a new pull request, #62:
URL: https://github.com/apache/pulsar-client-cpp/pull/62

   Fixes #61
   
   ### Motivation
   
   `testDestructor` is flaky because the destructor might not be called immediately after the `shared_ptr` object goes out of the scope. It's similar like the flaky `testReferenceCount` before in https://github.com/apache/pulsar/pull/17645.
   
   ### Modifications
   
   Add back `WaitUtils.h`, which was removed in #55, add use `waitUntil` to wait until the assertion.
   
   ### Verifications
   
   Run the reproduce script in #61. Even if the loop count was increased to 100, it still never failed.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-cpp] merlimat merged pull request #62: [flaky tests] Fix flaky ShutdownTest::testDestructor

[GitBox <gi...@apache.org>]

merlimat merged PR #62:
URL: https://github.com/apache/pulsar-client-cpp/pull/62


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org