You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/03/21 20:49:26 UTC
[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate
fangyu.rao@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12819
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate
......................................................................
IMPALA-4865: Reject Expr Rewrite When Appropriate
Avoided rewrite if the resulting string literal exceeds a defined limit.
Testing:
Added two statements in testFoldConstantsRule() to verify that the
expression rewrite is accepted only when the size of the rewritten
expression is below a specified threshold.
Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632
---
M fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/12819/1
--
To view, visit http://gerrit.cloudera.org:8080/12819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12819 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2508/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 21:33:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12819 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12819/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java:
http://gerrit.cloudera.org:8080/#/c/12819/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java@70
PS1, Line 70: if (((StringLiteral) result).getStringValue().length() > MAX_STRING_LITERAL_SIZE)
I think we actually want to do this on the C++ side before it is sent to Java. The problem with doing it on the Java side is that at this point we have already allocated a Java string literal up to 2GB in addition to the C++ string.
One follow-on from this is that we'd like to be able to run tests with smaller JVM heap sizes (e.g. 2GB).
--
To view, visit http://gerrit.cloudera.org:8080/12819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 20:54:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
fangyu.rao@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/12819 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate
......................................................................
Abandoned
Duplicate
--
To view, visit http://gerrit.cloudera.org:8080/12819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <fa...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>