[GitHub] [calcite] danny0405 commented on a change in pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin…

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin…
URL: https://github.com/apache/calcite/pull/1497#discussion_r333881474
 
 

 ##########
 File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
 ##########
 @@ -428,7 +428,7 @@ static Connection connect() throws SQLException {
           + " h varchar(3) not null,\n"
           + " i varchar(3),\n"
           + " j int not null as (char_length(h)) virtual,\n"
-          + " k varchar(3) null as (trim(i)) virtual)";
+          + " k varchar(3) null as (rtrim(i)) virtual)";
 
 Review comment:
   Changed from `trim` to `rtrim` because i also want to test operators for sql dialect, here it is the `ORACLE`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services