[GitHub] [airflow] potiuk commented on a change in pull request #17618: Fix redacting secrets in context exceptions.

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #17618:
URL: https://github.com/apache/airflow/pull/17618#discussion_r688982373



##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -144,6 +144,11 @@ def _record_attrs_to_ignore(self) -> Iterable[str]:
         )
         return frozenset(record.__dict__).difference({'msg', 'args'})
 
+    def _redact_exception_with_context(self, exception):
+        exception.args = (self.redact(v) for v in exception.args)
+        if exception.__context__:

Review comment:
       Yeah. https://www.python.org/dev/peps/pep-3134/ . I never before saw the "from" syntax, but yeah... __cause__ should be there as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org