You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "jerolba (via GitHub)" <gi...@apache.org> on 2025/09/21 10:23:02 UTC

[PR] GH-3321 Exclude package-info.class from shaded fastutil dependency [parquet-java]

jerolba opened a new pull request, #3322:
URL: https://github.com/apache/parquet-java/pull/3322

   ### Rationale for this change
   
   I've noticed that some JARs include `package-info.class` files from the shaded `it.unimi.dsi:fastutil` dependency.
   
   These files are located in packages that are otherwise empty and I believe these `package-info.class` files are unnecessary, even in artifacts that make use of other fastutil classes.
   
   ### What changes are included in this PR?
   
   Filtering these files out in the maven-shade-plugin configuration to reduce the final JAR size.
   
   ### Are these changes tested?
   
   No, apart of existing build process.
   
   ### Are there any user-facing changes?
   
   No
   
   Closes #3321
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3321 Exclude package-info.class from shaded fastutil dependency [parquet-java]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #3322:
URL: https://github.com/apache/parquet-java/pull/3322#issuecomment-3319985983

   I agree that it doesn't make sense to shade `package-info.class`, maybe we should completely remove it:
   
   ```xml
   <filters>
     <filter>
       <artifact>*:*</artifact>
       <excludes>
         <exclude>**/package-info.class</exclude>
       </excludes>
     </filter>
   </filters>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3321 Exclude package-info.class from shaded fastutil dependency [parquet-java]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3322:
URL: https://github.com/apache/parquet-java/pull/3322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3321 Exclude package-info.class from shaded fastutil dependency [parquet-java]

Posted by "jerolba (via GitHub)" <gi...@apache.org>.
jerolba commented on PR #3322:
URL: https://github.com/apache/parquet-java/pull/3322#issuecomment-3320020272

   I have found it just from fastutil dependency.
   
   I have no strong opinion on whether to explicitly manage this from fastutil or to generalize the rule for future changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org