[GitHub] [lucene-solr] HoustonPutman opened a new pull request #951: SOLR-13844: Remove replica recovery terms with the replica term

[GitBox <gi...@apache.org>]

HoustonPutman opened a new pull request #951: SOLR-13844: Remove replica recovery terms with the replica term
URL: https://github.com/apache/lucene-solr/pull/951
 
 
   # Description
   
   Currently if a recovering replica is deleted, the term for that core in the shard's terms in ZK is removed. However the `<core>_recovering` term is not removed as well. This can create clutter and confusion in the shard terms ZK node.
   
   # Solution
   
   When a core is removed from the shardTerms, the corresponding recovering term is removed if it exists.
   
   # Tests
   
   Added a test to make sure that corresponding terms are removed.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org