You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2017/09/05 10:36:25 UTC
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/1322
[CARBONDATA-1450] Support timestamp more than 68 years, Enhance NoDic…
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/incubator-carbondata timestamp_support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1322
----
commit e33fb0be76b4f6127f95e1ab49c782363f017e37
Author: dhatchayani <dh...@gmail.com>
Date: 2017-09-05T10:24:28Z
[CARBONDATA-1450] Support timestamp more than 68 years, Enhance NoDictionary Datatypes - int , long
----
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by QACarbonData <gi...@git.apache.org>.
Github user QACarbonData commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/29/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/693/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/856/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/698/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/55/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/532/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/216/
---
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1322
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/657/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/841/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/116/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/138/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/221/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/847/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/772/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/854/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/12/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/178/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/150/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/602/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/557/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/210/
---
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1322#discussion_r139395991
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java ---
@@ -211,10 +213,21 @@ private static Object getDirectDictionaryDefaultValue(DataType dataType, byte[]
* @param defaultValue
* @return
*/
- private static Object getNoDictionaryDefaultValue(byte[] defaultValue) {
+ private static Object getNoDictionaryDefaultValue(DataType datatype, byte[] defaultValue) {
Object noDictionaryDefaultValue = null;
if (!isDefaultValueNull(defaultValue)) {
- noDictionaryDefaultValue = UTF8String.fromBytes(defaultValue);
+ switch (datatype) {
+ case INT:
+ noDictionaryDefaultValue = ByteUtil.toInt(defaultValue, 0, defaultValue.length);
+ break;
+ case LONG:
+ case TIMESTAMP:
+ long timestampValue = ByteUtil.toLong(defaultValue, 0, defaultValue.length);
--- End diff --
handled
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/652/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/93/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/97/
---
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1322#discussion_r139389587
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala ---
@@ -31,6 +31,42 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE origintable1 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
}
+ test("create table sort columns dictionary include - int") {
--- End diff --
Add test cases for Int and Long no-Dictionary cases
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/570/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/852/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/738/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/571/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/790/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/599/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/747/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/855/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/20/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/223/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/567/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/161/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/225/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/167/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/86/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/13/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/131/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/605/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/99/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/597/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/224/
---
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1322#discussion_r139395822
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala ---
@@ -31,6 +31,42 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE origintable1 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
}
+ test("create table sort columns dictionary include - int") {
--- End diff --
added
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/527/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
Retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/566/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/700/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/101/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/739/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/112/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/569/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/42/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/568/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
Retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/809/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/589/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/11/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/590/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/692/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/796/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/100/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/110/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1322
retest this please
---
[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1322#discussion_r139386365
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java ---
@@ -211,10 +213,21 @@ private static Object getDirectDictionaryDefaultValue(DataType dataType, byte[]
* @param defaultValue
* @return
*/
- private static Object getNoDictionaryDefaultValue(byte[] defaultValue) {
+ private static Object getNoDictionaryDefaultValue(DataType datatype, byte[] defaultValue) {
Object noDictionaryDefaultValue = null;
if (!isDefaultValueNull(defaultValue)) {
- noDictionaryDefaultValue = UTF8String.fromBytes(defaultValue);
+ switch (datatype) {
+ case INT:
+ noDictionaryDefaultValue = ByteUtil.toInt(defaultValue, 0, defaultValue.length);
+ break;
+ case LONG:
+ case TIMESTAMP:
+ long timestampValue = ByteUtil.toLong(defaultValue, 0, defaultValue.length);
--- End diff --
Here Long case to be separately handled.
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/851/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/846/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/694/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/849/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/91/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/780/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/595/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/749/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/12/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/115/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/218/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/691/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1322
please refer to #1265, which use adaptive encoding for timestamp and date column.
I think it is better to solve 68 year issue after #1265 is merged
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/581/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/146/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1322
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/108/
---
[GitHub] carbondata issue #1322: [CARBONDATA-1450] Support timestamp more than 68 yea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1322
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/754/
---