You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/08 17:46:00 UTC
Review Request 71028: Renamed the roles ui column from 'Allocation' to
'Allocation + Offered'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71028/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Repository: mesos
Description
-------
This column actually displays the allocation + offered amount, so this
renames it accordingly to avoid confusion. Later, we will split these
apart into separate selectable columns.
Diffs
-----
src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478
Diff: https://reviews.apache.org/r/71028/diff/1/
Testing
-------
make check and rendered the UI locally
File Attachments
----------------
Roles Table
https://reviews.apache.org/media/uploaded/files/2019/07/08/41785a71-2676-4ff6-8653-2d10442605e1__Screen_Shot_2019-07-08_at_1.43.37_PM.png
Thanks,
Benjamin Mahler
Re: Review Request 71028: Renamed the roles ui column from
'Allocation' to 'Allocation + Offered'.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71028/#review216429
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On July 8, 2019, 10:46 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71028/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 10:46 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This column actually displays the allocation + offered amount, so this
> renames it accordingly to avoid confusion. Later, we will split these
> apart into separate selectable columns.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478
>
>
> Diff: https://reviews.apache.org/r/71028/diff/1/
>
>
> Testing
> -------
>
> make check and rendered the UI locally
>
>
> File Attachments
> ----------------
>
> Roles Table
> https://reviews.apache.org/media/uploaded/files/2019/07/08/41785a71-2676-4ff6-8653-2d10442605e1__Screen_Shot_2019-07-08_at_1.43.37_PM.png
>
>
> Thanks,
>
> Benjamin Mahler
>
>