You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/07/31 14:31:48 UTC
[PR] feat(soft-delete): warn at startup when the purge beat entry is missing [superset]
mikebridge opened a new pull request, #42641:
URL: https://github.com/apache/superset/pull/42641
### SUMMARY
Operators who redefine `CeleryConfig` in `superset_config.py` — instead of subclassing or merging the default — silently lose beat-schedule entries. For the soft-delete purge task (`deletion_retention.purge_soft_deleted`) this failure mode is invisible until it matters: archived objects accumulate forever instead of purging after the retention window.
This generalizes the existing startup check for the version-history retention entry (`_warn_if_retention_beat_missing`) to also cover the purge task:
- The version-history entry is checked unconditionally, as before (shadow rows written by prior deploys keep ageing even when capture is off).
- The purge entry is checked only when the `SOFT_DELETE` feature flag resolves **on** at the config level (`DEFAULT_FEATURE_FLAGS` merged with `FEATURE_FLAGS`, matching `FeatureFlagManager.init_app` order). The purge task itself no-ops while the flag is off, so a missing entry is only actionable once soft delete is live. Flags supplied dynamically via `GET_FEATURE_FLAGS_FUNC` are deliberately not consulted — this is a configuration-only startup diagnostic.
All four documented `CELERY_CONFIG` shapes (`None`, class/module, dict, dotted string) behave as before, and matching is by each entry's `task` value, not the schedule key, so a correctly-scheduled task under a renamed key does not warn.
This is groundwork for eventually enabling `SOFT_DELETE` by default: the warning must exist before any release ships with soft delete on, so deployments with hand-rolled Celery configs learn about the missing purge entry from the deploy log rather than from unbounded growth.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — log-only change. New warning text:
```
soft-delete: CELERY_CONFIG.beat_schedule is missing the 'deletion_retention.purge_soft_deleted' entry — archived objects will never be purged and will accumulate indefinitely. Either inherit from the default CeleryConfig or add the entry to your override.
```
### TESTING INSTRUCTIONS
1. `pytest tests/unit_tests/initialization_test.py -k RetentionBeatWarning` — 12 tests: 7 pre-existing plus 5 new covering the purge entry (warn when flag on + entry missing, silent when flag off, `FEATURE_FLAGS` override beats the default, silent when both entries present, renamed-key parity).
2. Manually: set `FEATURE_FLAGS = {"SOFT_DELETE": True}` and a `CELERY_CONFIG` class without the purge entry in `superset_config.py`; start the app; the warning above appears once at startup. Restore the default `CeleryConfig`; no warning.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Required feature flags: `SOFT_DELETE` (the new warning only fires when it resolves on)
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5193660771
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5195058251
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e6184dd8ca50ebda13579ec8fd9fd71c280301b9 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a7371cacaa61b000826601b |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-42641--superset-docs-preview.netlify.app](https://deploy-preview-42641--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5wS1Q6wc9Y13FglLZiojo73mbw7xQpez1hAmgAy-UeWk-WCHiiE7VS1JUPtKpbpK85tReiHUrzxzaNGQHi0xMZNBrrV1vjEYP3w8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42641--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #42641:
URL: https://github.com/apache/superset/pull/42641#discussion_r3720534641
##########
superset/initialization/__init__.py:
##########
@@ -945,6 +984,40 @@ def _warn_if_retention_beat_missing(self) -> None:
"default CeleryConfig or add the entry to your override.",
self._RETENTION_TASK_NAME,
)
+ if self._RETENTION_TASK_MODULE not in imported_modules:
+ logger.warning(
+ "versioning: CELERY_CONFIG.imports is missing %r — workers "
+ "will not register the retention task, so a scheduled run "
+ "fails with NotRegistered. Either inherit from the default "
+ "CeleryConfig or add the module to your override.",
+ self._RETENTION_TASK_MODULE,
+ )
+ # Resolve the gate exactly as the purge task does, so the warning
+ # cannot disagree with the no-op it is predicting.
+ # configure_feature_flags() runs before this check, so the manager
+ # is fully initialised here.
+ if feature_flag_manager.is_feature_enabled("SOFT_DELETE") and (
+ not beat_schedule or self._PURGE_TASK_NAME not in registered_tasks
+ ):
Review Comment:
**Suggestion:** The startup diagnostic is supposed to resolve `SOFT_DELETE` from the static `DEFAULT_FEATURE_FLAGS` merged with `FEATURE_FLAGS`, but `is_feature_enabled` may invoke the deployment-supplied `GET_FEATURE_FLAGS_FUNC`. A dynamic, request-dependent, or otherwise overridden result can therefore suppress or create a startup warning even though the configured flag is enabled or disabled. Read the merged configuration-level flags directly for this diagnostic rather than using the runtime feature-flag resolver. [incorrect condition logic]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Startup diagnostic can miss missing purge schedules.
- ⚠️ Operators receive warnings unrelated to static configuration.
- ⚠️ Archived objects may accumulate without deploy-log visibility.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=66ef8e6966f3432cb9415da4632e4849&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=66ef8e6966f3432cb9415da4632e4849&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/initialization/__init__.py
**Line:** 999:1001
**Comment:**
*Incorrect Condition Logic: The startup diagnostic is supposed to resolve `SOFT_DELETE` from the static `DEFAULT_FEATURE_FLAGS` merged with `FEATURE_FLAGS`, but `is_feature_enabled` may invoke the deployment-supplied `GET_FEATURE_FLAGS_FUNC`. A dynamic, request-dependent, or otherwise overridden result can therefore suppress or create a startup warning even though the configured flag is enabled or disabled. Read the merged configuration-level flags directly for this diagnostic rather than using the runtime feature-flag resolver.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42641&comment_hash=bd1d67460389b1f196bd50ddd38897a98e74d0ca4377791c45df51dcee7989e4&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42641&comment_hash=bd1d67460389b1f196bd50ddd38897a98e74d0ca4377791c45df51dcee7989e4&reaction=dislike'>👎</a>
##########
superset/initialization/__init__.py:
##########
@@ -945,6 +984,40 @@ def _warn_if_retention_beat_missing(self) -> None:
"default CeleryConfig or add the entry to your override.",
self._RETENTION_TASK_NAME,
)
+ if self._RETENTION_TASK_MODULE not in imported_modules:
+ logger.warning(
+ "versioning: CELERY_CONFIG.imports is missing %r — workers "
+ "will not register the retention task, so a scheduled run "
+ "fails with NotRegistered. Either inherit from the default "
+ "CeleryConfig or add the module to your override.",
+ self._RETENTION_TASK_MODULE,
+ )
Review Comment:
**Suggestion:** `CELERY_CONFIG.imports` is not the authoritative set of modules registered with a worker: Celery can load task modules through `include`, autodiscovery, worker command-line imports, or imports performed elsewhere during worker startup. A deployment using one of those mechanisms will have the task registered successfully but will still receive an actionable-looking missing-import warning. Check the actual Celery task registry after configuration, or limit this diagnostic to configurations where `imports` is explicitly the registration mechanism. [api mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Valid Celery deployments receive false startup warnings.
- ⚠️ Operators may incorrectly modify working worker configuration.
- ⚠️ Diagnostic trust is reduced for retention setup.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c1e9d6c05e8d4c0da909457e2ae4f332&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c1e9d6c05e8d4c0da909457e2ae4f332&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/initialization/__init__.py
**Line:** 987:994
**Comment:**
*Api Mismatch: `CELERY_CONFIG.imports` is not the authoritative set of modules registered with a worker: Celery can load task modules through `include`, autodiscovery, worker command-line imports, or imports performed elsewhere during worker startup. A deployment using one of those mechanisms will have the task registered successfully but will still receive an actionable-looking missing-import warning. Check the actual Celery task registry after configuration, or limit this diagnostic to configurations where `imports` is explicitly the registration mechanism.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42641&comment_hash=1c92a5b0e09b523e65c1a6d30eb1959bc15fe4ce7d4822a11b30f7387a0ccb42&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42641&comment_hash=1c92a5b0e09b523e65c1a6d30eb1959bc15fe4ce7d4822a11b30f7387a0ccb42&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5195048870
Addressed both CodeAnt findings in `e6184dd8ca`:
- Import diagnostics run only when `CELERY_CONFIG.imports` is explicitly configured; an absent setting may use `include`, autodiscovery, worker command-line imports, or startup imports and no longer produces a false warning.
- The `SOFT_DELETE` startup gate uses merged `DEFAULT_FEATURE_FLAGS` and `FEATURE_FLAGS` rather than dynamic request-time resolvers.
- Added the absent-imports negative test, inverted the dynamic-resolver test, updated `UPDATING.md`, and synchronized the PR description.
Verification: 16 retention-warning tests pass; MyPy, affected-file pre-commit, and the repository-wide checks pass with only the previously documented unrelated frontend formatter skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when the purge beat entry is missing [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5144043438
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42641?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.85%. Comparing base ([`7d2b184`](https://app.codecov.io/gh/apache/superset/commit/7d2b184079811d07fd3f525f1b3592987095474a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a0c35eb`](https://app.codecov.io/gh/apache/superset/commit/a0c35eb7b3a871603487e84e2d2be166c0961c1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/42641?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/initialization/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/42641?src=pr&el=tree&filepath=superset%2Finitialization%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/42641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7d2b184) and HEAD (a0c35eb). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (7d2b184) | HEAD (a0c35eb) |
>|------|------|------|
>|python|6|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42641 +/- ##
==========================================
- Coverage 65.44% 55.85% -9.60%
==========================================
Files 2810 2810
Lines 159362 159366 +4
Branches 36372 36373 +1
==========================================
- Hits 104301 89018 -15283
- Misses 53019 69515 +16496
+ Partials 2042 833 -1209
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.98% <50.00%> (+<0.01%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.98% <50.00%> (-19.28%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/42641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42641?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42641:
URL: https://github.com/apache/superset/pull/42641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when a retention task's Celery config is incomplete [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5196970217
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): warn at startup when the purge beat entry is missing [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42641:
URL: https://github.com/apache/superset/pull/42641#issuecomment-5144000536
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org