You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/16 12:46:03 UTC

[GitHub] [avro] martin-g opened a new pull request, #1829: AVRO-3609: [Rust] Add support for custom attributes

martin-g opened a new pull request, #1829:
URL: https://github.com/apache/avro/pull/1829

   
   ### Jira
   
   - [X] https://issues.apache.org/jira/browse/AVRO-3609
   
   ### Tests
   
   - [X] My PR adds unit tests
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] Adds rustdoc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] untereiner commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
untereiner commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1217785776

   My use case is to read custom attributes at the top-level of a schema.
   So I guess nothing is missing in the current implementation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] martin-g commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1217889999

   Yes! 
   But you could try it now by pointing to a local checkout or git:// . I'd be thankful if you test it now so we can fix any problems before making a proper release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] untereiner commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
untereiner commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1217888195

   I guess I have to wait until next release to use it directly from crates.io ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] martin-g commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1217707265

   Is there anything missing in the current implementation ?
   I need use cases to decide what should be done next.
   At the moment the implementation can read custom attributes at top-level and record field level. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] martin-g commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1216637574

   @untereiner Please take a look and tell what you think! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] martin-g commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1217847954

   Thanks for the review, @untereiner !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] martin-g merged pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
martin-g merged PR #1829:
URL: https://github.com/apache/avro/pull/1829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [avro] untereiner commented on pull request #1829: AVRO-3609: [Rust] Add support for custom attributes

Posted by GitBox <gi...@apache.org>.
untereiner commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1216692672

   I am a rust beginner so I can not comment the code but for what I know it seems good. 
   I find it very good to output serde_json::Value types instead of strings like in the c++ version.
   
   > Do we want to support serializing the custom attributes?
   this is what is ambiguous in the spec for me.
   
   I understand this: 
   > where typeName is either a primitive or derived type name, as defined below. Attributes not defined in this document are permitted as metadata, but must not affect the format of serialized data
   
   as not serializing to not modify the format of serialized data
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org