You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 08:45:08 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #9067: [Rust] [Breaking] Migrated MutableBuffer::freeze to From for Buffer

jorgecarleitao opened a new pull request #9067:
URL: https://github.com/apache/arrow/pull/9067


   A small modification of the `MutableBuffer`'s API to use `std`'s trait for convertion to `Buffer`.
   
   `std` offers a trait exactly for this. This PR just uses it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9067: [Rust] [Breaking] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753453320


   > Maybe keep `freeze` public and add a deprecation message, @alamb @nevi-me ?
   
   Yes, I'd opt to do that. Then we can remove `freeze` in 4.0 or 5.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9067: ARROW-11105: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753458892


   https://issues.apache.org/jira/browse/ARROW-11105


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9067: [Rust] [Breaking] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753287418


   Maybe keep `freeze` public and add a deprecation message?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9067: ARROW-11105: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9067:
URL: https://github.com/apache/arrow/pull/9067


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9067: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753456318


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=h1) Report
   > Merging [#9067](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=desc) (e2a93f6) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **increase** coverage by `0.00%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9067/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9067   +/-   ##
   =======================================
     Coverage   82.55%   82.56%           
   =======================================
     Files         203      203           
     Lines       50043    50046    +3     
   =======================================
   + Hits        41315    41319    +4     
   + Misses       8728     8727    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Jvb2xlYW4ucnM=) | `98.20% <ø> (ø)` | |
   | [...ion-testing/src/bin/arrow-json-integration-test.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9iaW4vYXJyb3ctanNvbi1pbnRlZ3JhdGlvbi10ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <66.66%> (ø)` | |
   | [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <83.33%> (ø)` | |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <100.00%> (ø)` | |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `90.83% <100.00%> (+4.32%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `92.32% <100.00%> (+0.68%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (ø)` | |
   | [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `84.00% <100.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=footer). Last update [cd22be6...553dd99](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9067: ARROW-11105: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753456318


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=h1) Report
   > Merging [#9067](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=desc) (73e35fa) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **decrease** coverage by `0.00%`.
   > The diff coverage is `90.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9067/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9067      +/-   ##
   ==========================================
   - Coverage   82.55%   82.55%   -0.01%     
   ==========================================
     Files         203      203              
     Lines       50043    50046       +3     
   ==========================================
   + Hits        41315    41317       +2     
   - Misses       8728     8729       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Jvb2xlYW4ucnM=) | `98.20% <ø> (ø)` | |
   | [...ion-testing/src/bin/arrow-json-integration-test.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9iaW4vYXJyb3ctanNvbi1pbnRlZ3JhdGlvbi10ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <66.66%> (ø)` | |
   | [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <83.33%> (ø)` | |
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <92.30%> (-0.49%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <100.00%> (ø)` | |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `90.83% <100.00%> (+4.32%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `92.32% <100.00%> (+0.68%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (ø)` | |
   | ... and [13 more](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=footer). Last update [cd22be6...1819e05](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9067: ARROW-11105: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753456318


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=h1) Report
   > Merging [#9067](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=desc) (1819e05) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **increase** coverage by `0.00%`.
   > The diff coverage is `90.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9067/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9067   +/-   ##
   =======================================
     Coverage   82.55%   82.56%           
   =======================================
     Files         203      203           
     Lines       50043    50046    +3     
   =======================================
   + Hits        41315    41318    +3     
     Misses       8728     8728           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Jvb2xlYW4ucnM=) | `98.20% <ø> (ø)` | |
   | [...ion-testing/src/bin/arrow-json-integration-test.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9iaW4vYXJyb3ctanNvbi1pbnRlZ3JhdGlvbi10ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <66.66%> (ø)` | |
   | [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <83.33%> (ø)` | |
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <92.30%> (-0.49%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <100.00%> (ø)` | |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `90.83% <100.00%> (+4.32%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `92.32% <100.00%> (+0.68%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=footer). Last update [cd22be6...1819e05](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9067: [Rust] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753456318


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=h1) Report
   > Merging [#9067](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=desc) (553dd99) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **decrease** coverage by `0.00%`.
   > The diff coverage is `90.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9067/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9067      +/-   ##
   ==========================================
   - Coverage   82.55%   82.55%   -0.01%     
   ==========================================
     Files         203      203              
     Lines       50043    50046       +3     
   ==========================================
   + Hits        41315    41317       +2     
   - Misses       8728     8729       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Jvb2xlYW4ucnM=) | `98.20% <ø> (ø)` | |
   | [...ion-testing/src/bin/arrow-json-integration-test.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9iaW4vYXJyb3ctanNvbi1pbnRlZ3JhdGlvbi10ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <66.66%> (ø)` | |
   | [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <83.33%> (ø)` | |
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <92.30%> (-0.49%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <100.00%> (ø)` | |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `90.83% <100.00%> (+4.32%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `92.32% <100.00%> (+0.68%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (ø)` | |
   | ... and [13 more](https://codecov.io/gh/apache/arrow/pull/9067/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=footer). Last update [cd22be6...553dd99](https://codecov.io/gh/apache/arrow/pull/9067?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9067: [Rust] [Breaking] Migrated MutableBuffer::freeze to From for Buffer

Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #9067:
URL: https://github.com/apache/arrow/pull/9067#issuecomment-753287418


   Maybe keep `freeze` public and add a deprecation message, @alamb @nevi-me ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org