You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Darryl L. Miles (JIRA)" <ji...@apache.org> on 2012/08/06 18:36:03 UTC
[jira] [Created] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Darryl L. Miles created DIRMINA-903:
---------------------------------------
Summary: DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
Key: DIRMINA-903
URL: https://issues.apache.org/jira/browse/DIRMINA-903
Project: MINA
Issue Type: Bug
Components: Core
Affects Versions: 2.0.4
Reporter: Darryl L. Miles
DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
The return value of this method should be EITHER be the existing value set or the default valur provided in the 3rd argument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Attachment: mina-core-r1369395-2.0.patch
PATCH for branches/2.0 r1369395
corrects minor whitespace formatting inline with other parts of the file.
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Attachment: mina-core-r1369395-2.0.patch
PATCH for branches/2.0 r1369395
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default valur provided in the 3rd argument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Description:
DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
was:
DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
The return value of this method should be EITHER be the existing value set or the default valur provided in the 3rd argument.
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429308#comment-13429308 ]
Emmanuel Lecharny commented on DIRMINA-903:
-------------------------------------------
Thanks Daryl !
I have fixed https://issues.apache.org/jira/browse/DIRMINA-871 last month, but it seems that I have overlooked the Javadoc.
Just applied your patch, slightly modified. (http://svn.apache.org/viewvc?rev=1369900&view=rev)
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Attachment: (was: mina-core-r1369395-2.0.patch)
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429260#comment-13429260 ]
Darryl L. Miles commented on DIRMINA-903:
-----------------------------------------
Taken a quick look at MINA v3 and the ./core/src/main/java/org/apache/mina/session/DefaultAttributeContainer.java doesn't look like it has this problem.
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Attachment: mina-core-r1369395-2.0.patch
PATCH for branches/2.0 r1369395
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default valur provided in the 3rd argument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Darryl L. Miles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated DIRMINA-903:
------------------------------------
Attachment: (was: mina-core-r1369395-2.0.patch)
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default valur provided in the 3rd argument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DIRMINA-903)
DefaultIoSessionData#getAttribute(String,Object,Object) return value does
not follow documentation
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRMINA-903.
---------------------------------------
Resolution: Fixed
patch applied (http://svn.apache.org/viewvc?rev=1369900&view=rev)
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation
> ---------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-903
> URL: https://issues.apache.org/jira/browse/DIRMINA-903
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.4
> Reporter: Darryl L. Miles
> Attachments: mina-core-r1369395-2.0.patch
>
>
> DefaultIoSessionData#getAttribute(String,Object,Object) return value does not follow documentation.
> The return value of this method should be EITHER be the existing value set or the default value provided in the 3rd argument.
> This 2nd version of the patch fixes test cases failures I've seen from the ftpserver-core project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira