You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2022/04/23 23:35:09 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request, #174: OPENMEETINGS-2726 Add some border styles to quick poll fixed popup
sebawagner opened a new pull request, #174:
URL: https://github.com/apache/openmeetings/pull/174
Add some styles to quick poll popup:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #174: OPENMEETINGS-2726 Add some border styles to quick poll fixed popup
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #174:
URL: https://github.com/apache/openmeetings/pull/174#discussion_r857273410
##########
openmeetings-web/src/main/webapp/css/raw-room.css:
##########
@@ -671,7 +671,10 @@ html[dir="rtl"] .room-block .sb-wb .sidebar {
right: 40px;
bottom: 40px;
padding: 5px;
- background-color: var(--bs-info);
+ border: 1px solid;
+ border-radius: 0.2rem;
+ background-color: white;
Review Comment:
True I'll change it to --bs-light
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner merged pull request #174: OPENMEETINGS-2726 Add some border styles to quick poll fixed popup
Posted by GitBox <gi...@apache.org>.
sebawagner merged PR #174:
URL: https://github.com/apache/openmeetings/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a diff in pull request #174: OPENMEETINGS-2726 Add some border styles to quick poll fixed popup
Posted by GitBox <gi...@apache.org>.
solomax commented on code in PR #174:
URL: https://github.com/apache/openmeetings/pull/174#discussion_r857239319
##########
openmeetings-web/src/main/webapp/css/raw-room.css:
##########
@@ -671,7 +671,10 @@ html[dir="rtl"] .room-block .sb-wb .sidebar {
right: 40px;
bottom: 40px;
padding: 5px;
- background-color: var(--bs-info);
+ border: 1px solid;
+ border-radius: 0.2rem;
+ background-color: white;
Review Comment:
Would this hardcode looks good in case for ex. this https://bootswatch.com/darkly/ theme is selected?
Should we use some `--bs-` color variable here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org