You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Freedman (JIRA)" <de...@myfaces.apache.org> on 2008/07/09 20:55:31 UTC
[jira] Created: (PORTLETBRIDGE-43) MyFaces action handling
sometimes fails with exception from ExternalContext
setRequestCharacterSetEncoding
MyFaces action handling sometimes fails with exception from ExternalContext setRequestCharacterSetEncoding
----------------------------------------------------------------------------------------------------------
Key: PORTLETBRIDGE-43
URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-43
Project: MyFaces Portlet Bridge
Issue Type: Bug
Components: Impl
Affects Versions: 1.0.0, 2.0.0
Reporter: Michael Freedman
Assignee: Michael Freedman
In some configurations (noteably when Facelets is used), an exception is thrown when MyFaces tries to set the request character encoding during an action. The exception claims that the request (parameters) have already been read and hence one can't do this set. This occurs because the Bridge reads the request parameters during ExternalContext construction to determine the view target of the request (if encodes this target in a render parameter). Fix is to delay determining the view until Faces actually tries to determine it itself. I.e. Don't resolve the view until either EC.getRequestPathInfo or EC.getRequestServletPath are called. Note: because at least older version of the Faces RI we support don't call these (in the portlet case) but rather relies on a request attribute being set -- the bridge must also detect/resolve the view for this case as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PORTLETBRIDGE-43) MyFaces action handling
sometimes fails with exception from ExternalContext
setRequestCharacterSetEncoding
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Freedman resolved PORTLETBRIDGE-43.
-------------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
1.0.0
As per previous comment. I have now merged this code from the 1.0 code line to the 2.0 codeline so bug is fixed in both versions. See description for general info on fix.
> MyFaces action handling sometimes fails with exception from ExternalContext setRequestCharacterSetEncoding
> ----------------------------------------------------------------------------------------------------------
>
> Key: PORTLETBRIDGE-43
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-43
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: Impl
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Michael Freedman
> Assignee: Michael Freedman
> Fix For: 1.0.0, 2.0.0
>
>
> In some configurations (noteably when Facelets is used), an exception is thrown when MyFaces tries to set the request character encoding during an action. The exception claims that the request (parameters) have already been read and hence one can't do this set. This occurs because the Bridge reads the request parameters during ExternalContext construction to determine the view target of the request (if encodes this target in a render parameter). Fix is to delay determining the view until Faces actually tries to determine it itself. I.e. Don't resolve the view until either EC.getRequestPathInfo or EC.getRequestServletPath are called. Note: because at least older version of the Faces RI we support don't call these (in the portlet case) but rather relies on a request attribute being set -- the bridge must also detect/resolve the view for this case as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-43) MyFaces action handling
sometimes fails with exception from ExternalContext
setRequestCharacterSetEncoding
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616701#action_12616701 ]
Michael Freedman commented on PORTLETBRIDGE-43:
-----------------------------------------------
This has been fixed in the Portlet 1.0 Bridge codeline but hasn't yet been fixed in the 2.0 codeline hence the bug is left open as a reminder to merge the work.
> MyFaces action handling sometimes fails with exception from ExternalContext setRequestCharacterSetEncoding
> ----------------------------------------------------------------------------------------------------------
>
> Key: PORTLETBRIDGE-43
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-43
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: Impl
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Michael Freedman
> Assignee: Michael Freedman
>
> In some configurations (noteably when Facelets is used), an exception is thrown when MyFaces tries to set the request character encoding during an action. The exception claims that the request (parameters) have already been read and hence one can't do this set. This occurs because the Bridge reads the request parameters during ExternalContext construction to determine the view target of the request (if encodes this target in a render parameter). Fix is to delay determining the view until Faces actually tries to determine it itself. I.e. Don't resolve the view until either EC.getRequestPathInfo or EC.getRequestServletPath are called. Note: because at least older version of the Faces RI we support don't call these (in the portlet case) but rather relies on a request attribute being set -- the bridge must also detect/resolve the view for this case as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.