You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/14 03:46:25 UTC
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3229: [KYUUBI #3170] Expose thrift binary connection metrics
pan3793 commented on code in PR #3229:
URL: https://github.com/apache/incubator-kyuubi/pull/3229#discussion_r945224276
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConstants.scala:
##########
@@ -32,6 +32,7 @@ object MetricsConstants {
final private val CONN = KYUUBI + "connection."
final private val THRIFT_HTTP_CONN = KYUUBI + "thrift.http.connection."
+ final private val BINARY_FRONTEND_CONNECTION = KYUUBI + "binary.frontend.connection."
Review Comment:
```suggestion
final private val THRIFT_BINARY_CONN = KYUUBI + "thrift.binary.connection."
```
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConstants.scala:
##########
@@ -32,6 +32,7 @@ object MetricsConstants {
final private val CONN = KYUUBI + "connection."
final private val THRIFT_HTTP_CONN = KYUUBI + "thrift.http.connection."
+ final private val BINARY_FRONTEND_CONNECTION = KYUUBI + "binary.frontend.connection."
Review Comment:
```suggestion
final private val THRIFT_BINARY_CONN = KYUUBI + "thrift.binary.connection."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org