[GitHub] [airflow] nuclearpinguin commented on issue #5335: [AIRFLOW-4588] Add GoogleDiscoveryApiHook and GoogleApiToS3Transfer

[GitBox <gi...@apache.org>]

nuclearpinguin commented on issue #5335: [AIRFLOW-4588] Add GoogleDiscoveryApiHook and GoogleApiToS3Transfer
URL: https://github.com/apache/airflow/pull/5335#issuecomment-524891738
 
 
   I like this approach because it's really generic. On the other hand, I also like service-specific hooks where user can see how the discovery request is build: 
   ```python
   self.get_conn().projects().locations().functions().get().execute()
   ```
   especially when I think about _"Explicit is better than implicit."_.
   
   I would opt for using this generic hook in operators based on discovery API. Meaning that we will not require operator + hook pair for every service. The main advantage of this is having code in one place. Moreover, it would be really easy to create new operators using this hook.
   
   However, I would suggest to incorporate proposed functionalities into already present `GoogleCloudBaseHook` to keep all gcp logic in one class. 
   
   WDYT @potiuk @mik-laj @feluelle 
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services