[GitHub] [hbase] wchevreuil commented on a change in pull request #3383: HBASE-26000 Optimize the display of ZK dump in the master web UI

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #3383:
URL: https://github.com/apache/hbase/pull/3383#discussion_r650760702



##########
File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1857,12 +1857,14 @@ public static String dump(ZKWatcher zkw) {
           sb.append("\n ").append(child);
         }
       }
-      sb.append("\nRegion server holding hbase:meta: "
-        + MetaTableLocator.getMetaRegionLocation(zkw));
+      sb.append("\nRegion server holding hbase:meta:");
+      sb.append("\n ").append(MetaTableLocator.getMetaRegionLocation(zkw));
       int numMetaReplicas = zkw.getMetaReplicaNodes().size();
-      for (int i = 1; i < numMetaReplicas; i++) {
-        sb.append("\nRegion server holding hbase:meta, replicaId " + i + " "
-                    + MetaTableLocator.getMetaRegionLocation(zkw, i));
+      if (numMetaReplicas > 1) {

Review comment:
       nit: This extra check is redundant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org