[GitHub] [arrow] ViniciusSouzaRoque commented on a change in pull request #12655: ARROW-15962: [C++][GANDIVA] Fix unhex errors return

[GitBox <gi...@apache.org>]

ViniciusSouzaRoque commented on a change in pull request #12655:
URL: https://github.com/apache/arrow/pull/12655#discussion_r831384784



##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -2736,24 +2736,24 @@ const char* to_hex_int32(int64_t context, int32_t data, int32_t* out_len) {
 
 FORCE_INLINE
 const char* from_hex_utf8(int64_t context, const char* text, int32_t text_len,
-                          int32_t* out_len) {
+                          bool text_validity, bool* out_valid, int32_t* out_len) {

Review comment:
       In this case, i suppose that need returns same a text_len == 0 used below, returning a true for out_valid and one empty string
   I go add this on union with that case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org