You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by Nicholas Lesiecki <nd...@yahoo.com> on 2003/09/25 08:30:20 UTC
Clover?
As you all know, I am a big proponent of advanced testing techniques. (Heh,
I guess anyone following this list probably is.) So, on the whole, I like
the idea of Clover. However, I'd like to raise the question of whether we
think it's providing enough benefit to the development effort to justify its
continued existence in our build process. (Much in the spirit of Chris
questioning AspectJ's contribution to the project.)
Do we look at the clover reports often? Do our users use them? Do they help
us increase our code coverage? Or are we ignoring them? I ask because I
don't have a clear idea of the benefits, only of the cost, which is the
frustration of trying to turn the dratted thing off in the build script.
(Why am I trying to turn it off?--Because I don't have a license...another
problem though you all may have a good solution to it.) Clover also adds to
the build's general complexity.
So what do the developers think? Is it pulling its weight?
Cheers,
Nick
P.S. I won't argue with the conclusions, I just want to raise the question.
Re: Mavenizing!
Posted by Julien Dubois <ju...@julien-dubois.com>.
Hello everybody,
3 things concerning Maven :
1. CVS access
I can't do a "cvs add" as I've got no write access. At least that's the error
message I got.
So I put my new files here : http://www.julien-dubois.com/jakarta-cactus/
So I just did this (attached) mostly worthless patch.
I'm using Cervisia (it's the default CVS GUI embedded into Konqueror) to
create the patch. Tell me if it's working ok.
2. Building the documentation
I can't generate the documentation with the current navigation.xml files.
Using the Maven/xdocs format, they should be like this :
http://picocontainer.cvs.codehaus.org/viewcvs.cgi/*checkout*/pico/xdocs/
navigation.xml?content-type=text%2Fplain&rev=1.26&root=picocontainer
IMHO, we should copy the current navigation.xml files to some
navigation-cactus.xml files, and do a search'n replace in the current Ant
code.
Then we'll be able to have normal navigation.xml files.
I'll do them, no problem, I did many of those last week at work.
3. Testing & mock objects
With my current Maven files, some of the tests will not run. I know it, I've
got to learn how to use Mock objects first. Because for the moment I've got
no idea how this is supposed to work. I'll learn that this week.
Julien.
Re: Mavenizing!
Posted by Christopher Lenz <cm...@gmx.de>.
Julien Dubois wrote:
> Hi guys,
>
> I was following your Clover discussion : we'll also need a license for the
> maven-clover-plugin.
>
> Vincent : can you create empty files (project.xml, project.properties,
> maven.xml) in all the samples/ and integration/ subprojects?
> I'll then be able to send you some patches.
Please not that you can inlude new files in your patch. You just need to
"cvs add" them, and then run "cvs diff -N -u" (where the -N option means
"include new files").
The only scenario where this does not work is if you need new
directories, which need to be present in CVS and thus require you to
have write access to the repo. But IIUC there is no need for new
directories here, so the normal patch-creation procedure should be enough.
--
Christopher Lenz
/=/ cmlenz at gmx.d
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
Re: Mavenizing!
Posted by Christopher Lenz <cm...@gmx.de>.
Julien Dubois wrote:
> Hi guys,
>
> I was following your Clover discussion : we'll also need a license for the
> maven-clover-plugin.
>
> Vincent : can you create empty files (project.xml, project.properties,
> maven.xml) in all the samples/ and integration/ subprojects?
> I'll then be able to send you some patches.
Please not that you can inlude new files in your patch. You just need to
"cvs add" them, and then run "cvs diff -N -u" (where the -N option means
"include new files").
The only scenario where this does not work is if you need new
directories, which need to be present in CVS and thus require you to
have write access to the repo. But IIUC there is no need for new
directories here, so the normal patch-creation procedure should be enough.
--
Christopher Lenz
/=/ cmlenz at gmx.d
RE: Mavenizing!
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Julien Dubois [mailto:julien@julien-dubois.com]
> Sent: 27 September 2003 12:56
> To: Cactus Developers List
> Subject: Mavenizing!
>
> Hi guys,
>
> I was following your Clover discussion : we'll also need a license for
the
> maven-clover-plugin.
We have one already... I'm sending the jar to you by private email. Just
drop it in your ANTHOME/lib directory. That said you don't need to use
it to build cactus unless you use the top level "ant release" target or
you turn clovering on.
>
> Vincent : can you create empty files (project.xml, project.properties,
> maven.xml) in all the samples/ and integration/ subprojects?
> I'll then be able to send you some patches.
Julien, can you send us the full files by email to the cactus dev
mailing lists. We'll then commit them and you will then be able to send
patches against them.
Thanks
-Vincent
>
> Julien.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
RE: Mavenizing!
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Julien Dubois [mailto:julien@julien-dubois.com]
> Sent: 27 September 2003 12:56
> To: Cactus Developers List
> Subject: Mavenizing!
>
> Hi guys,
>
> I was following your Clover discussion : we'll also need a license for
the
> maven-clover-plugin.
We have one already... I'm sending the jar to you by private email. Just
drop it in your ANTHOME/lib directory. That said you don't need to use
it to build cactus unless you use the top level "ant release" target or
you turn clovering on.
>
> Vincent : can you create empty files (project.xml, project.properties,
> maven.xml) in all the samples/ and integration/ subprojects?
> I'll then be able to send you some patches.
Julien, can you send us the full files by email to the cactus dev
mailing lists. We'll then commit them and you will then be able to send
patches against them.
Thanks
-Vincent
>
> Julien.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
Mavenizing!
Posted by Julien Dubois <ju...@julien-dubois.com>.
Hi guys,
I was following your Clover discussion : we'll also need a license for the
maven-clover-plugin.
Vincent : can you create empty files (project.xml, project.properties,
maven.xml) in all the samples/ and integration/ subprojects?
I'll then be able to send you some patches.
Julien.
Mavenizing!
Posted by Julien Dubois <ju...@julien-dubois.com>.
Hi guys,
I was following your Clover discussion : we'll also need a license for the
maven-clover-plugin.
Vincent : can you create empty files (project.xml, project.properties,
maven.xml) in all the samples/ and integration/ subprojects?
I'll then be able to send you some patches.
Julien.
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
Re: Clover?
Posted by Christopher Lenz <cm...@gmx.de>.
Vincent Massol wrote:
> Hi Nick,
>
> You don't see the value because we're still missing the important bit
> which is to automatically fail the build when the coverage percentage is
> below a threshold. We'll get there one day :-
>
> OTOH, I use Clover from time to time to tell me where tests should be
> written. I don't look often but I like to have it when I need it.
I also use the clover reports from time to time... but they should be
optional in the build process. I actually believe they are *optional*, and
we have a flag (clover.enable) to enable it. Doesn't that flag work?
> I do agree we could possibly do without the web reports. However, that
> only costs some space on the web server. I'd be okay to remove the
> clover reports from the zip distribution though because they're taking
> so much space.
+1. We could actually hardwire the link in the docs to the online version,
to avoid a broken link in the local docs.
> WRT the license we have a license for Cactus and I can send you the
> clover jar for Cactus if you wish.
Yeah. When I started working on Cactus, I simply dropped the Clover guys a
mail [1], and told them I was committer on the project (with something like
a link to the contributors page as proof). I got back a link for downloading
a team licenced version in (almost) no time. I guess we could just forward
that link to you privately.
-chris
[1] I see they now have a form for the process:
http://www.thecortex.net/clover/freelicense.jsp
> Thanks
> -Vincent
>
>>-----Original Message-----
>>From: Nicholas Lesiecki [mailto:ndlesiecki@yahoo.com]
>>Sent: 25 September 2003 08:30
>>To: Cactus Developers List
>>Subject: Clover?
>>
>>As you all know, I am a big proponent of advanced testing techniques.
>>(Heh,
>>I guess anyone following this list probably is.) So, on the whole, I
>
> like
>
>>the idea of Clover. However, I'd like to raise the question of whether
>
> we
>
>>think it's providing enough benefit to the development effort to
>
> justify
>
>>its
>>continued existence in our build process. (Much in the spirit of Chris
>>questioning AspectJ's contribution to the project.)
>>
>>Do we look at the clover reports often? Do our users use them? Do they
>>help
>>us increase our code coverage? Or are we ignoring them? I ask because
>
> I
>
>>don't have a clear idea of the benefits, only of the cost, which is
>
> the
>
>>frustration of trying to turn the dratted thing off in the build
>
> script.
>
>>(Why am I trying to turn it off?--Because I don't have a
>
> license...another
>
>>problem though you all may have a good solution to it.) Clover also
>
> adds
>
>>to
>>the build's general complexity.
>>
>>So what do the developers think? Is it pulling its weight?
>>
>>
>>Cheers,
>>Nick
>>
>>P.S. I won't argue with the conclusions, I just want to raise the
>>question.
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
Re: Clover?
Posted by Christopher Lenz <cm...@gmx.de>.
Vincent Massol wrote:
> Hi Nick,
>
> You don't see the value because we're still missing the important bit
> which is to automatically fail the build when the coverage percentage is
> below a threshold. We'll get there one day :-
>
> OTOH, I use Clover from time to time to tell me where tests should be
> written. I don't look often but I like to have it when I need it.
I also use the clover reports from time to time... but they should be
optional in the build process. I actually believe they are *optional*, and
we have a flag (clover.enable) to enable it. Doesn't that flag work?
> I do agree we could possibly do without the web reports. However, that
> only costs some space on the web server. I'd be okay to remove the
> clover reports from the zip distribution though because they're taking
> so much space.
+1. We could actually hardwire the link in the docs to the online version,
to avoid a broken link in the local docs.
> WRT the license we have a license for Cactus and I can send you the
> clover jar for Cactus if you wish.
Yeah. When I started working on Cactus, I simply dropped the Clover guys a
mail [1], and told them I was committer on the project (with something like
a link to the contributors page as proof). I got back a link for downloading
a team licenced version in (almost) no time. I guess we could just forward
that link to you privately.
-chris
[1] I see they now have a form for the process:
http://www.thecortex.net/clover/freelicense.jsp
> Thanks
> -Vincent
>
>>-----Original Message-----
>>From: Nicholas Lesiecki [mailto:ndlesiecki@yahoo.com]
>>Sent: 25 September 2003 08:30
>>To: Cactus Developers List
>>Subject: Clover?
>>
>>As you all know, I am a big proponent of advanced testing techniques.
>>(Heh,
>>I guess anyone following this list probably is.) So, on the whole, I
>
> like
>
>>the idea of Clover. However, I'd like to raise the question of whether
>
> we
>
>>think it's providing enough benefit to the development effort to
>
> justify
>
>>its
>>continued existence in our build process. (Much in the spirit of Chris
>>questioning AspectJ's contribution to the project.)
>>
>>Do we look at the clover reports often? Do our users use them? Do they
>>help
>>us increase our code coverage? Or are we ignoring them? I ask because
>
> I
>
>>don't have a clear idea of the benefits, only of the cost, which is
>
> the
>
>>frustration of trying to turn the dratted thing off in the build
>
> script.
>
>>(Why am I trying to turn it off?--Because I don't have a
>
> license...another
>
>>problem though you all may have a good solution to it.) Clover also
>
> adds
>
>>to
>>the build's general complexity.
>>
>>So what do the developers think? Is it pulling its weight?
>>
>>
>>Cheers,
>>Nick
>>
>>P.S. I won't argue with the conclusions, I just want to raise the
>>question.
RE: Clover?
Posted by Vincent Massol <vm...@pivolis.com>.
Hi Nick,
You don't see the value because we're still missing the important bit
which is to automatically fail the build when the coverage percentage is
below a threshold. We'll get there one day :-
OTOH, I use Clover from time to time to tell me where tests should be
written. I don't look often but I like to have it when I need it.
I do agree we could possibly do without the web reports. However, that
only costs some space on the web server. I'd be okay to remove the
clover reports from the zip distribution though because they're taking
so much space.
WRT the license we have a license for Cactus and I can send you the
clover jar for Cactus if you wish.
Thanks
-Vincent
> -----Original Message-----
> From: Nicholas Lesiecki [mailto:ndlesiecki@yahoo.com]
> Sent: 25 September 2003 08:30
> To: Cactus Developers List
> Subject: Clover?
>
> As you all know, I am a big proponent of advanced testing techniques.
> (Heh,
> I guess anyone following this list probably is.) So, on the whole, I
like
> the idea of Clover. However, I'd like to raise the question of whether
we
> think it's providing enough benefit to the development effort to
justify
> its
> continued existence in our build process. (Much in the spirit of Chris
> questioning AspectJ's contribution to the project.)
>
> Do we look at the clover reports often? Do our users use them? Do they
> help
> us increase our code coverage? Or are we ignoring them? I ask because
I
> don't have a clear idea of the benefits, only of the cost, which is
the
> frustration of trying to turn the dratted thing off in the build
script.
> (Why am I trying to turn it off?--Because I don't have a
license...another
> problem though you all may have a good solution to it.) Clover also
adds
> to
> the build's general complexity.
>
> So what do the developers think? Is it pulling its weight?
>
>
> Cheers,
> Nick
>
> P.S. I won't argue with the conclusions, I just want to raise the
> question.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
RE: Clover?
Posted by Vincent Massol <vm...@pivolis.com>.
Hi Nick,
You don't see the value because we're still missing the important bit
which is to automatically fail the build when the coverage percentage is
below a threshold. We'll get there one day :-
OTOH, I use Clover from time to time to tell me where tests should be
written. I don't look often but I like to have it when I need it.
I do agree we could possibly do without the web reports. However, that
only costs some space on the web server. I'd be okay to remove the
clover reports from the zip distribution though because they're taking
so much space.
WRT the license we have a license for Cactus and I can send you the
clover jar for Cactus if you wish.
Thanks
-Vincent
> -----Original Message-----
> From: Nicholas Lesiecki [mailto:ndlesiecki@yahoo.com]
> Sent: 25 September 2003 08:30
> To: Cactus Developers List
> Subject: Clover?
>
> As you all know, I am a big proponent of advanced testing techniques.
> (Heh,
> I guess anyone following this list probably is.) So, on the whole, I
like
> the idea of Clover. However, I'd like to raise the question of whether
we
> think it's providing enough benefit to the development effort to
justify
> its
> continued existence in our build process. (Much in the spirit of Chris
> questioning AspectJ's contribution to the project.)
>
> Do we look at the clover reports often? Do our users use them? Do they
> help
> us increase our code coverage? Or are we ignoring them? I ask because
I
> don't have a clear idea of the benefits, only of the cost, which is
the
> frustration of trying to turn the dratted thing off in the build
script.
> (Why am I trying to turn it off?--Because I don't have a
license...another
> problem though you all may have a good solution to it.) Clover also
adds
> to
> the build's general complexity.
>
> So what do the developers think? Is it pulling its weight?
>
>
> Cheers,
> Nick
>
> P.S. I won't argue with the conclusions, I just want to raise the
> question.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org