[GitHub] [nifi] pvillard31 commented on a change in pull request #4053: NIFI-7142: Automatically handle schema drift in the PutKudu processor

[GitBox <gi...@apache.org>]

pvillard31 commented on a change in pull request #4053: NIFI-7142: Automatically handle schema drift in the PutKudu processor
URL: https://github.com/apache/nifi/pull/4053#discussion_r379099968
 
 

 ##########
 File path: nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
 ##########
 @@ -255,12 +272,45 @@ private void trigger(final ProcessContext context, final ProcessSession session,
             final OperationType operationType = OperationType.valueOf(context.getProperty(INSERT_OPERATION).evaluateAttributeExpressions(flowFile).getValue());
             final Boolean ignoreNull = Boolean.valueOf(context.getProperty(IGNORE_NULL).evaluateAttributeExpressions(flowFile).getValue());
             final Boolean lowercaseFields = Boolean.valueOf(context.getProperty(LOWERCASE_FIELD_NAMES).evaluateAttributeExpressions(flowFile).getValue());
+            final Boolean handleSchemaDrift = Boolean.valueOf(context.getProperty(HANDLE_SCHEMA_DRIFT).evaluateAttributeExpressions(flowFile).getValue());
 
 Review comment:
   Same comment applies here. And if you do add a specific attribute to be evaluated against (something like ${handle.schema.drift}), you'll need to check if the attribute does exist in the flow file, otherwise you would have a NPE here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services