You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "alexeyinkin (via GitHub)" <gi...@apache.org> on 2023/02/01 13:16:05 UTC
[GitHub] [beam] alexeyinkin opened a new pull request, #25254: Playground Frontend Test workflow (#24728)
alexeyinkin opened a new pull request, #25254:
URL: https://github.com/apache/beam/pull/25254
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1095473855
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
Review Comment:
They remind us that we want to get formatting right and clean lints. And uncommenting them is easier than adding anew.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1095473062
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ - name: 'Test playground_components'
+ working-directory: playground/frontend/playground_components
+ run: flutter test
+
+ - name: 'Test playground'
Review Comment:
Yes. These are directory names. ToB will run tests in `tour-of-beam` and `playground_components`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1099047955
##########
playground/frontend/README.md:
##########
@@ -164,9 +164,12 @@ flutter test
Integration tests currently can be run only on a local development machine.
Server testing has not been verified yet.
-1. Install and run Chrome Driver: https://chromedriver.chromium.org/downloads
-2. Run it on port 4444: `chromedriver --port=4444`
-3. Run:
+1. Install Google Chrome: https://www.google.com/chrome/
+2. Install Chrome Driver: https://chromedriver.chromium.org/downloads
+ - Note: This GitHub action installs both Chrome and Chrome Driver:
+ https://github.com/nanasess/setup-chromedriver/blob/a249caaaad10fd12103028fd509853c2229eb6e6/lib/setup-chromedriver.sh
Review Comment:
FYI writing this comment for future reference in case we run into problems. The following worked for me on a Compute Engine Instance, matching the run job's `Ubuntu 22.04.1 LTS version`, and not the install google-chrome command in the [nanasess/setup-chromedriver](https://github.com/nanasess/setup-chromedriver/blob/a249caaaad10fd12103028fd509853c2229eb6e6/lib/setup-chromedriver.sh#L12) script.
On Ubuntu 22.04 (and on Debian not shown) the following error results from `sudo apt-get install -y google-chrome`
`E: Unable to locate package google-chrome`
Instead I did:
```
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt install ./google-chrome-stable_current_amd64.deb
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25254:
URL: https://github.com/apache/beam/pull/25254#issuecomment-1415341185
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1095477963
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
Review Comment:
Unfortunately, this will be the 9th location where we hardcode the Flutter version, and the workflow for ToB will be the 10th one. We will add it to the list in
- https://github.com/apache/beam/issues/23243
once this is merged. I do not have a solution with less redundancy for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1096435678
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ - name: 'Test playground_components'
+ working-directory: playground/frontend/playground_components
+ run: flutter test
+
+ - name: 'Test playground'
+ working-directory: playground/frontend
+ run: flutter test
+
+ - uses: nanasess/setup-chromedriver@v1
+
+ - name: 'Integration tests'
+ run: |
+ cp playground/frontend/lib/config.example.dart playground/frontend/lib/config.g.dart
+ chromedriver --port=4444 &
+ ./gradlew :playground:frontend:integrationTest -PdeviceId=web-server
Review Comment:
Yes, here is a complete run of this workflow: https://github.com/akvelon/beam/actions/runs/4071779100/jobs/7013898331
chromedriver requires Chrome to be installed. I just added that to README.
This workflow uses this GitHub action to install both Chrome and Chrome Driver:
https://github.com/marketplace/actions/setup-chromedriver
Here's where it does it:
https://github.com/nanasess/setup-chromedriver/blob/a249caaaad10fd12103028fd509853c2229eb6e6/lib/setup-chromedriver.sh#L12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Malarg commented on pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "Malarg (via GitHub)" <gi...@apache.org>.
Malarg commented on PR #25254:
URL: https://github.com/apache/beam/pull/25254#issuecomment-1413436491
LGTM (internal review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1096337475
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ - name: 'Test playground_components'
+ working-directory: playground/frontend/playground_components
+ run: flutter test
+
+ - name: 'Test playground'
+ working-directory: playground/frontend
+ run: flutter test
+
+ - uses: nanasess/setup-chromedriver@v1
+
+ - name: 'Integration tests'
+ run: |
+ cp playground/frontend/lib/config.example.dart playground/frontend/lib/config.g.dart
+ chromedriver --port=4444 &
+ ./gradlew :playground:frontend:integrationTest -PdeviceId=web-server
Review Comment:
Were you able to get the chromedriver to work in GitHub actions prior to submitting this PR?
I got the following error using Cloud Shell.
```
> Task :playground:frontend:integrationTest_standalone_change_example_sdk_run
Downloading Web SDK... 2,499ms
Downloading CanvasKit... 424ms
Running "flutter pub get" in frontend... 2,898ms
Launching integration_test/standalone_change_example_sdk_run_test.dart on Web Server in debug mode...
Waiting for connection from debug service on Web Server... 54.2s
integration_test/standalone_change_example_sdk_run_test.dart is being served at http://localhost:34205
The web-server device requires the Dart Debug Chrome extension for debugging. Consider using the Chrome or Edge devices for an improved development workflow.
UnknownException (13): unknown error: cannot find Chrome binary
(Driver info: chromedriver=110.0.5481.30 (aedb656755c469651f01505a4f15e153fc606a1e-refs/branch-heads/5481@{#191}),platform=Linux 5.15.65+ x86_64)
#0 parseJsonWireResponse (package:webdriver/src/handler/json_wire/utils.dart:82:9)
#1 JsonWireSessionHandler.parseInfoResponse (package:webdriver/src/handler/json_wire/session.dart:27:21)
#2 JsonWireSessionHandler.parseCreateResponse (package:webdriver/src/handler/json_wire/session.dart:18:7)
#3 InferSessionHandler.parseCreateResponse (package:webdriver/src/handler/infer_handler.dart:100:39)
#4 AsyncRequestClient.send (package:webdriver/src/common/request_client.dart:96:32)
<asynchronous suspension>
#5 createDriver (package:webdriver/async_core.dart:64:19)
<asynchronous suspension>
#6 WebDriverService.startTest (package:flutter_tools/src/drive/web_driver_service.dart:146:19)
<asynchronous suspension>
#7 DriveCommand.runCommand (package:flutter_tools/src/commands/drive.dart:275:30)
<asynchronous suspension>
#8 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1209:27)
<asynchronous suspension>
#9 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#10 CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#11 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#12 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#13 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
<asynchronous suspension>
#14 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
<asynchronous suspension>
#15 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#16 main (package:flutter_tools/executable.dart:91:3)
<asynchronous suspension>
> Task :playground:frontend:integrationTest_standalone_change_example_sdk_run FAILED
FAILURE: Build failed with an exception.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #25254:
URL: https://github.com/apache/beam/pull/25254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1094267471
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
Review Comment:
Is it the single source of truth for the project's Flutter version? Should it be stored here?
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
Review Comment:
Maybe delete the comments?
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ - name: 'Test playground_components'
+ working-directory: playground/frontend/playground_components
+ run: flutter test
+
+ - name: 'Test playground'
Review Comment:
Will ToB need such workflow? If so, should the project name be mentioned in the job names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25254:
URL: https://github.com/apache/beam/pull/25254#issuecomment-1413224268
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on PR #25254:
URL: https://github.com/apache/beam/pull/25254#issuecomment-1415338465
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25254:
URL: https://github.com/apache/beam/pull/25254#issuecomment-1422945974
lgtm thanks y'all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1094267471
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
Review Comment:
Is this the single source of truth for the project's Flutter version? Should it be stored here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org