[kudu-CR] [client] KUDU-2966 configure connection negotiation timeout

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16687 )

Change subject: [client] KUDU-2966 configure connection negotiation timeout
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client-test.cc@898
PS1, Line 898: auto s = b.Build(&c);
             :     ASSERT_OK(s);
nit: inline the ASSERT? Same below


http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client-test.cc@911
PS1, Line 911: timeout
nit: kConstNamingScheme?


http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client-test.cc@919
PS1, Line 919: Initialized
nit: isn't this taken care of by the comparison?


http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/16687/1/src/kudu/client/client.h@268
PS1, Line 268: If not provided, the underlying messenger is created with reasonable
             :   /// default. The result value could be retrieved using
             :   /// @c KuduClient.connection_negotiation_timeout() after an instance of
             :   /// @c KuduClient is created.
nit: Would it make sense to add a small blurb about what connection negotiation is, and why it might be slow?



-- 
To view, visit http://gerrit.cloudera.org:8080/16687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8573a572887be041637e28e518a7cd3a6d1f1693
Gerrit-Change-Number: 16687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Nov 2020 05:30:07 +0000
Gerrit-HasComments: Yes