You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/26 11:18:43 UTC

[GitHub] [rocketmq] vongosling commented on a change in pull request #2376: [ISSUE #2374] Fix error in ipCheck method

vongosling commented on a change in pull request #2376:
URL: https://github.com/apache/rocketmq/pull/2376#discussion_r511886131



##########
File path: common/src/main/java/org/apache/rocketmq/common/UtilAll.java
##########
@@ -461,33 +461,9 @@ private static boolean ipCheck(byte[] ip) {
         if (ip.length != 4) {

Review comment:
       Is it a necessary judgment here? Although you use the InetAddressValidator, I would like to recommend you solve the problem thoroughly. BTW, Hopefully, you could continue to optimize this class. There are many implementations that can be replaced by existing libs. I would like to follow your process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org