You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/13 16:03:51 UTC

[GitHub] [fineract] vorburger opened a new pull request #759: set fineract_tenants_* more nicely in docker-compose.yml

vorburger opened a new pull request #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759
 
 
   We can use environment variables instead of system properties.
   
   We originally had to use system properties and could not use environment variables, because these used to read by Tomcat, but since the switch to Hikari in FINERACT-796 these are read by Spring Boot instead of Tomcat, so we can now use system properties.
   
   This both "looks nicer" and is useful e.g. for FINERACT-881.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
awasum commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759#issuecomment-613977757
 
 
   This is now passing. Do you want to merge this @vorburger ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger merged pull request #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759#issuecomment-613046996
 
 
   This failed due to what #762 will fix (work around, deactivating test); let's rebase this once that is in.
   
   @xurror you're probably interested in this change, see my comment in FINERACT-881.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum closed pull request #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
awasum closed pull request #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
awasum commented on issue #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759#issuecomment-613933658
 
 
   #764 has been merged. lets run this or rebase with develop and see.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger opened a new pull request #759: set fineract_tenants_* more nicely in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
vorburger opened a new pull request #759: set fineract_tenants_* more nicely in docker-compose.yml
URL: https://github.com/apache/fineract/pull/759
 
 
   We can use environment variables instead of system properties.
   
   We originally had to use system properties and could not use environment variables, because these used to read by Tomcat, but since the switch to Hikari in FINERACT-796 these are read by Spring Boot instead of Tomcat, so we can now use system properties.
   
   This both "looks nicer" and is useful e.g. for FINERACT-881.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services