You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by eo...@apache.org on 2019/07/27 12:48:10 UTC

[bookkeeper] branch branch-4.8 updated: Make build pass on JDK11, fix javadoc configuration

This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a commit to branch branch-4.8
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/branch-4.8 by this push:
     new 5e5d7a3  Make build pass on JDK11, fix javadoc configuration
5e5d7a3 is described below

commit 5e5d7a386b4725324f3fcff756039feb11d7c875
Author: Enrico Olivelli <eo...@gmail.com>
AuthorDate: Sat Jul 27 14:47:07 2019 +0200

    Make build pass on JDK11, fix javadoc configuration
    
    
    Descriptions of the changes in this PR:
    
    ### Motivation
    
    Build fails on recent JDK11 versions and on JDK11, see #2133, this is because javadoc has problems with references to core Java API when source version is set to 8.
    
    ### Changes
    Upgrade Java doc plugin to latest 3.1.1 and disable auto linking to core Java classes with
    `<detectJavaApiLink>false</detectJavaApiLink>
    `
    Closes #2133
    
    
    
    
    Reviewers: Sijie Guo <None>
    
    This closes #2134 from eolivelli/fix/javadoc-jdk11
    
    (cherry picked from commit 5311e00f399ae3b5cb39fe03d8b5dd8c0547de14)
    Signed-off-by: eolivelli <eo...@apache.org>
---
 pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 26b9c13..14d5bea 100644
--- a/pom.xml
+++ b/pom.xml
@@ -175,7 +175,7 @@
     <maven-deploy-plugin.version>2.7</maven-deploy-plugin.version>
     <maven-install-plugin.version>2.5.1</maven-install-plugin.version>
     <maven-jar-plugin.version>2.4</maven-jar-plugin.version>
-    <maven-javadoc-plugin.version>3.0.0</maven-javadoc-plugin.version>
+    <maven-javadoc-plugin.version>3.1.1</maven-javadoc-plugin.version>
     <maven-shade-plugin.version>3.1.0</maven-shade-plugin.version>
     <maven-source-plugin.version>2.2.1</maven-source-plugin.version>
     <maven-surefire-plugin.version>2.21.0</maven-surefire-plugin.version>
@@ -795,6 +795,7 @@
           <doctitle>BookKeeper Java API (version ${project.version})</doctitle>
           <overview>site/_site/overview/index.html</overview>
           <show>package</show>
+          <detectJavaApiLink>false</detectJavaApiLink>
         </configuration>
         <executions>
           <execution>