You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "wangshengjie123 (via GitHub)" <gi...@apache.org> on 2023/12/05 09:39:17 UTC
[PR] [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application [incubator-celeborn]
wangshengjie123 opened a new pull request, #2131:
URL: https://github.com/apache/incubator-celeborn/pull/2131
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
When request slots, filter workers excluded by application
### Why are the changes needed?
If worker alive but can not service, register shuffle will remove the worker from application client exclude list and next shuffle may reserve slots on this worker，this will cause application revive unexpectly
### Does this PR introduce _any_ user-facing change?
Yes, request slots will filter workers excluded by application
### How was this patch tested?
UT,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2131:
URL: https://github.com/apache/incubator-celeborn/pull/2131#issuecomment-1840411781
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `6 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`50575d6`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/50575d633ceab62ebf6c62e927169d35551a6ae7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.27% compared to head [(`3ee52e3`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.39%.
> :exclamation: Current head 3ee52e3 differs from pull request most recent head 50a3def. Consider uploading reports for the commit 50a3def to get more accurate results
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
+ Coverage 47.27% 47.39% +0.12%
==========================================
Files 173 173
Lines 11039 11045 +6
Branches 1011 1011
==========================================
+ Hits 5218 5234 +16
+ Misses 5474 5466 -8
+ Partials 347 345 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2131?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2131: [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application
URL: https://github.com/apache/incubator-celeborn/pull/2131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application [incubator-celeborn]
Posted by "wangshengjie123 (via GitHub)" <gi...@apache.org>.
wangshengjie123 commented on code in PR #2131:
URL: https://github.com/apache/incubator-celeborn/pull/2131#discussion_r1423305571
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1241,7 +1245,8 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends
pushRackAwareEnabled,
userIdentifier,
slotsAssignMaxWorkers,
- availableStorageTypes)
+ availableStorageTypes,
+ workerStatusTracker.excludedWorkers.asScala.keys.toSet)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1151] Request slots when register shuffle should filter the workers excluded by application [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #2131:
URL: https://github.com/apache/incubator-celeborn/pull/2131#discussion_r1422086857
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1241,7 +1245,8 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends
pushRackAwareEnabled,
userIdentifier,
slotsAssignMaxWorkers,
- availableStorageTypes)
+ availableStorageTypes,
+ workerStatusTracker.excludedWorkers.asScala.keys.toSet)
Review Comment:
I think we'd better add a config to enable this feature to avoid the corner case where most of the workers are excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org