You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2023/05/13 16:31:05 UTC
[GitHub] [shardingsphere] iamhucong opened a new pull request, #25649: Synchronize the configuration of Checkstyle and Spotless
iamhucong opened a new pull request, #25649:
URL: https://github.com/apache/shardingsphere/pull/25649
Synchronize the configuration of Checkstyle and Spotless regarding the line breaks in annotation parameters.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on a diff in pull request #25649: Synchronize the configuration of Checkstyle and Spotless
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on code in PR #25649:
URL: https://github.com/apache/shardingsphere/pull/25649#discussion_r1193068410
##########
src/resources/spotless/java.xml:
##########
@@ -45,5 +45,6 @@
<setting id="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_constructor_declaration" value="106" />
<setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="106" />
<setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_explicit_constructor_call.count_dependent" value="16|5|80" />
+ <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_annotation" value="16" />
Review Comment:
0 - Default - Do not wrap
16 - Wrap where necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on pull request #25649: Synchronize the configuration of Checkstyle and Spotless
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on PR #25649:
URL: https://github.com/apache/shardingsphere/pull/25649#issuecomment-1546799309
@strongduanmu Hi, please help me review this when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on a diff in pull request #25649: Synchronize the configuration of Checkstyle and Spotless
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on code in PR #25649:
URL: https://github.com/apache/shardingsphere/pull/25649#discussion_r1193068410
##########
src/resources/spotless/java.xml:
##########
@@ -45,5 +45,6 @@
<setting id="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_constructor_declaration" value="106" />
<setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="106" />
<setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_explicit_constructor_call.count_dependent" value="16|5|80" />
+ <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_annotation" value="16" />
Review Comment:
0 - Default - Do not wrap
6 - Wrap where necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #25649: Synchronize the configuration of Checkstyle and Spotless
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #25649:
URL: https://github.com/apache/shardingsphere/pull/25649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org