You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "alexanderbianchi (via GitHub)" <gi...@apache.org> on 2026/09/07 18:48:48 UTC

[PR] feat(rest): support configurable page sizes [iceberg-rust]

alexanderbianchi opened a new pull request, #3168:
URL: https://github.com/apache/iceberg-rust/pull/3168

   ## Which issue does this PR close?
   
   Closes #2934.
   
   ## What changes are included in this PR?
   
   - Honor `rest-page-size` for namespace and table listings, resolving server defaults, client configuration, and server overrides in that order.
   - Add `REST_CATALOG_PROP_PAGE_SIZE` and `with_page_size(u32)` to both REST catalog builders. Properties passed to `load` take precedence over the builder setter.
   - Validate the effective page size after the lazy configuration handshake. Leave `pageSize` unset when no source configures it.
   - Send `pageSize` on every page request and an empty initial `pageToken` to opt into pagination, while continuing to collect all results.
   - Document configuring a REST catalog for DataFusion and add an end-to-end test proving that namespaces and tables from subsequent pages are visible through the provider and SQL. DataFusion continues to use the generic `Catalog` interface; no REST-specific production dependency or separate pagination setting is introduced.
   - Update the REST public API snapshot.
   
   ## Are these changes tested?
   
   - REST tests cover configuration precedence, missing configuration, invalid values, minimum/maximum sizes, multipart parents, opaque page-token encoding, and propagation across pages.
   - A DataFusion integration test uses a mock REST server to paginate namespace and table listings and checks the results through `information_schema.tables`.
   - `cargo test -p iceberg-catalog-rest -p iceberg-datafusion --lib --tests`: 181 tests passed.
   - `cargo clippy -p iceberg-catalog-rest -p iceberg-datafusion --all-targets -- -D warnings`: passed.
   - Formatting, `git diff --check`, and the generated REST public API snapshot were checked.
   
   ## AI Disclosure
   
   The implementation, tests, and documentation were developed with assistance from an AI coding agent.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat(rest): support configurable page sizes [iceberg-rust]

Posted by "alexanderbianchi (via GitHub)" <gi...@apache.org>.
alexanderbianchi closed pull request #3168: feat(rest): support configurable page sizes
URL: https://github.com/apache/iceberg-rust/pull/3168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] feat(rest): support configurable page sizes [iceberg-rust]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3168:
URL: https://github.com/apache/iceberg-rust/pull/3168#issuecomment-6049592541

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org