[GitHub] marcoabreu closed pull request #11874: [MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0

[GitBox <gi...@apache.org>]

marcoabreu closed pull request #11874: [MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0
URL: https://github.com/apache/incubator-mxnet/pull/11874
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ci/docker/runtime_functions.sh b/ci/docker/runtime_functions.sh
index 566ff18204d..21cd88542e0 100755
--- a/ci/docker/runtime_functions.sh
+++ b/ci/docker/runtime_functions.sh
@@ -812,7 +812,7 @@ build_docs() {
     set -ex
     pushd .
     cd /work/mxnet/docs/build_version_doc
-    ./build_all_version.sh $1
+    ./build_all_version.sh $1 $2
     ./update_all_version.sh $2 $3 $4
     cd VersionedWeb
     tar -zcvf ../artifacts.tgz .
diff --git a/docs/build_version_doc/build_all_version.sh b/docs/build_version_doc/build_all_version.sh
index 56b80e3a0fc..02816dd746f 100755
--- a/docs/build_version_doc/build_all_version.sh
+++ b/docs/build_version_doc/build_all_version.sh
@@ -30,13 +30,24 @@ set -x
 
 if [ -z "$1" ]
   then
-    echo "Please provide a list of version tags you wish to run."
+    echo "Please provide a list of version tags you wish to build."
     exit 1
   else
     IFS=$';'
-    tag_list=$1
-    echo "Using these tags: $tag_list"
-    for tag in $tag_list; do echo $tag; done
+    tags_to_build=$1
+    echo "Using these tags: $tags_to_build"
+    for tag in $tags_to_build; do echo $tag; done
+fi
+
+if [ -z "$2" ]
+  then
+    echo "Please provide a list of version tags you wish to display."
+    exit 1
+  else
+    IFS=$';'
+    tags_to_display=$2
+    echo "Using these tags: $tags_to_display"
+    for tag in $tags_to_display; do echo $tag; done
 fi
 
 mxnet_url="https://github.com/apache/incubator-mxnet.git"
@@ -53,8 +64,9 @@ if [ ! -d "$built" ]; then
   mkdir "$built/versions"
 fi
 
-# Build all versions and use latest version(First version number in $tag_list) as landing page.
-for tag in $tag_list; do
+# Build all versions and use latest version(First version number in $tags_to_build) as landing page.
+i = 0;
+for tag in $tags_to_build; do
     cd "$mxnet_folder"
     git fetch
     if [ $tag == 'master' ]
@@ -72,12 +84,14 @@ for tag in $tag_list; do
     make clean
     make html USE_OPENMP=1 || exit 1
     cd ../../
-    file_loc="$built/versions/$tag"
+    ancillary = $tags_to_display[$i]
+    file_loc="$built/versions/$ancillary"
     if [ -d "$file_loc" ] ; then
         rm -rf "$file_loc"
     fi
     mkdir "$file_loc"
     cp -a "$mxnet_folder/docs/_build/html/." "$file_loc"
+    i = $((i+1));
 done
 
 echo "Now you may want to run update_all_version.sh to create the production layout with the versions dropdown and other per-version corrections."


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services