You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/10 08:41:46 UTC
[GitHub] [incubator-iotdb] liutaohua opened a new pull request #727:
[IOTDB-412]Paths are not correctly deduplicated
liutaohua opened a new pull request #727: [IOTDB-412]Paths are not correctly deduplicated
URL: https://github.com/apache/incubator-iotdb/pull/727
In the previous design, we needed to move all the work removing the duplicate `Path` to the `PhysicalGenerator` class to do this, but without the `group by device` because it is a special way of working, we kept the deduplication work in the `DeviceIterateDataSet` class.
So, when a` group by device ` query after `PhysicalGenerator`, `deduplicatedPaths` and `deduplicatedDataTypes` should be an empty state, and the `paths` and `datatypes` should be meet the requirements of the implementation of `DeviceIterateDataSet` , for more complex description.
I created a `ut``PhysicalPlanTest.testDeduplicatedPath` to describe these things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request
#727: [IOTDB-412]Paths are not correctly deduplicated
Posted by GitBox <gi...@apache.org>.
liutaohua commented on a change in pull request #727: [IOTDB-412]Paths are not correctly deduplicated
URL: https://github.com/apache/incubator-iotdb/pull/727#discussion_r365134133
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -416,11 +418,12 @@ private void generateDataTypes(QueryPlan queryPlan) throws PathException {
}
private void deduplicate(QueryPlan queryPlan) {
+ if (queryPlan.isGroupByDevice()) {
+ return;
Review comment:
done, thanks for your advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request
#727: [IOTDB-412]Paths are not correctly deduplicated
Posted by GitBox <gi...@apache.org>.
jt2594838 commented on a change in pull request #727: [IOTDB-412]Paths are not correctly deduplicated
URL: https://github.com/apache/incubator-iotdb/pull/727#discussion_r365126747
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -416,11 +418,12 @@ private void generateDataTypes(QueryPlan queryPlan) throws PathException {
}
private void deduplicate(QueryPlan queryPlan) {
+ if (queryPlan.isGroupByDevice()) {
+ return;
Review comment:
Add a comment to explain this like "The deduplication of a GroupByDevice query is done in the dataset".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 merged pull request #727:
[IOTDB-412]Paths are not correctly deduplicated
Posted by GitBox <gi...@apache.org>.
jt2594838 merged pull request #727: [IOTDB-412]Paths are not correctly deduplicated
URL: https://github.com/apache/incubator-iotdb/pull/727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services