[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4201: Fix incorrect cast Timestamp with Timezone

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4201:
URL: https://github.com/apache/arrow-rs/pull/4201#discussion_r1191510727


##########
arrow-cast/src/cast.rs:
##########
@@ -2123,6 +2147,41 @@ pub fn cast_with_options(
     }
 }
 
+/// Parses a fixed offset of the form "+09:00", "-09" or "+0930"
+fn parse_offset_secs(tz: &str) -> Result<i64, ArrowError> {

Review Comment:
   Is there a reason for not using the DateTime abstractions I suggested? The code as written will not handle daylight savings correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org